[GitHub] [druid] gianm opened a new pull request #10754: OrFilter: Properly handle child matchers that return the original mask.

[GitBox <gi...@apache.org>]

gianm opened a new pull request #10754:
URL: https://github.com/apache/druid/pull/10754


   This happens when a child matcher is literally true (for example,
   BooleanVectorValueMatcher). In this case, OrFilter would throw this
   exception from its call to removeAll while processing the next filter:
   
     java.lang.IllegalStateException: 'other' must be a different instance from 'this'
   
   Also update the javadocs for VectorValueMatcher to call out that the
   returned object may be the same as the input mask.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm merged pull request #10754: OrFilter: Properly handle child matchers that return the original mask.

[GitBox <gi...@apache.org>]

gianm merged pull request #10754:
URL: https://github.com/apache/druid/pull/10754


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org