[GitHub] [hudi] eric9204 commented on a diff in pull request #8871: [HUDI-6308]add num_commits_after_last_request to flink

["eric9204 (via GitHub)" <gi...@apache.org>]

eric9204 commented on code in PR #8871:
URL: https://github.com/apache/hudi/pull/8871#discussion_r1213939610


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -642,6 +642,7 @@ private FlinkOptions() {
   public static final String TIME_ELAPSED = "time_elapsed";
   public static final String NUM_AND_TIME = "num_and_time";
   public static final String NUM_OR_TIME = "num_or_time";
+  public static final String NUM_COMMITS_AFTER_LAST_REQUEST = "num_commits_after_last_request";
   @AdvancedConfig
   public static final ConfigOption<String> COMPACTION_TRIGGER_STRATEGY = ConfigOptions

Review Comment:
   @danny0405 Thank you for your reply. 
   
   By adding this parameter `'compaction.trigger.strategy'='num_commits_after_last_request'`, in my test, the job can generate a compaction plan for every fixed number of `deltacommits`.
   
   I don't understand that "The variable may not be used anywhere". Is there a problem with this compaction trigger strategy in some scenarios?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org