You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2009/06/23 23:47:07 UTC
[jira] Created: (LUCENE-1716) Adding norms, properties indexing and
writer.infoStream support to benchmark
Adding norms, properties indexing and writer.infoStream support to benchmark
----------------------------------------------------------------------------
Key: LUCENE-1716
URL: https://issues.apache.org/jira/browse/LUCENE-1716
Project: Lucene - Java
Issue Type: Improvement
Reporter: Shai Erera
Priority: Minor
Fix For: 2.9
I would like to add the following support in benchmark:
# Ability to specify whether norms should be stored in the index.
# Ability to specify whether norms should be stored for the body field (assuming norms are usually stored for that field in real life applications, make it explicit)
# Ability to specify an infoStream for IndexWriter
# Ability to specify whether to index the properties returned on DocData (for content sources like TREC, these may include arbitrary <meta> tags, which we may not want to index).
Patch to come shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1716) Adding norms, properties indexing and
writer.infoStream support to benchmark
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-1716:
-------------------------------
Attachment: LUCENE-1716.patch
Patch includes the mentioned changes + unit tests. All benchmark tests pass. I think it's ready to commit.
> Adding norms, properties indexing and writer.infoStream support to benchmark
> ----------------------------------------------------------------------------
>
> Key: LUCENE-1716
> URL: https://issues.apache.org/jira/browse/LUCENE-1716
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1716.patch
>
>
> I would like to add the following support in benchmark:
> # Ability to specify whether norms should be stored in the index.
> # Ability to specify whether norms should be stored for the body field (assuming norms are usually stored for that field in real life applications, make it explicit)
> # Ability to specify an infoStream for IndexWriter
> # Ability to specify whether to index the properties returned on DocData (for content sources like TREC, these may include arbitrary <meta> tags, which we may not want to index).
> Patch to come shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1716) Adding norms, properties indexing
and writer.infoStream support to benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724024#action_12724024 ]
Michael McCandless commented on LUCENE-1716:
--------------------------------------------
OK that sounds like a good plan; I'll remove from my area before committing! I plan to commit in a day or two.
> Adding norms, properties indexing and writer.infoStream support to benchmark
> ----------------------------------------------------------------------------
>
> Key: LUCENE-1716
> URL: https://issues.apache.org/jira/browse/LUCENE-1716
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1716.patch
>
>
> I would like to add the following support in benchmark:
> # Ability to specify whether norms should be stored in the index.
> # Ability to specify whether norms should be stored for the body field (assuming norms are usually stored for that field in real life applications, make it explicit)
> # Ability to specify an infoStream for IndexWriter
> # Ability to specify whether to index the properties returned on DocData (for content sources like TREC, these may include arbitrary <meta> tags, which we may not want to index).
> Patch to come shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1716) Adding norms, properties indexing
and writer.infoStream support to benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724014#action_12724014 ]
Michael McCandless commented on LUCENE-1716:
--------------------------------------------
I'm hitting a failure here:
{code}
[junit] Testcase: testInfoStream_File(org.apache.lucene.benchmark.byTask.tasks.CreateIndexTaskTest): FAILED
[junit] creation of the file should have failed !
[junit] junit.framework.AssertionFailedError: creation of the file should have failed !
[junit] at org.apache.lucene.benchmark.byTask.tasks.CreateIndexTaskTest.testInfoStream_File(CreateIndexTaskTest.java:86)
[junit]
{code}
Apparently my OS (currently OpenSolaris 2009.06) has no problem creating a file called "*"... hmm.
> Adding norms, properties indexing and writer.infoStream support to benchmark
> ----------------------------------------------------------------------------
>
> Key: LUCENE-1716
> URL: https://issues.apache.org/jira/browse/LUCENE-1716
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1716.patch
>
>
> I would like to add the following support in benchmark:
> # Ability to specify whether norms should be stored in the index.
> # Ability to specify whether norms should be stored for the body field (assuming norms are usually stored for that field in real life applications, make it explicit)
> # Ability to specify an infoStream for IndexWriter
> # Ability to specify whether to index the properties returned on DocData (for content sources like TREC, these may include arbitrary <meta> tags, which we may not want to index).
> Patch to come shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1716) Adding norms, properties indexing
and writer.infoStream support to benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1716:
------------------------------------------
Assignee: Michael McCandless
> Adding norms, properties indexing and writer.infoStream support to benchmark
> ----------------------------------------------------------------------------
>
> Key: LUCENE-1716
> URL: https://issues.apache.org/jira/browse/LUCENE-1716
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1716.patch
>
>
> I would like to add the following support in benchmark:
> # Ability to specify whether norms should be stored in the index.
> # Ability to specify whether norms should be stored for the body field (assuming norms are usually stored for that field in real life applications, make it explicit)
> # Ability to specify an infoStream for IndexWriter
> # Ability to specify whether to index the properties returned on DocData (for content sources like TREC, these may include arbitrary <meta> tags, which we may not want to index).
> Patch to come shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1716) Adding norms, properties indexing
and writer.infoStream support to benchmark
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1716.
----------------------------------------
Resolution: Fixed
Thanks Shai!
> Adding norms, properties indexing and writer.infoStream support to benchmark
> ----------------------------------------------------------------------------
>
> Key: LUCENE-1716
> URL: https://issues.apache.org/jira/browse/LUCENE-1716
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1716.patch
>
>
> I would like to add the following support in benchmark:
> # Ability to specify whether norms should be stored in the index.
> # Ability to specify whether norms should be stored for the body field (assuming norms are usually stored for that field in real life applications, make it explicit)
> # Ability to specify an infoStream for IndexWriter
> # Ability to specify whether to index the properties returned on DocData (for content sources like TREC, these may include arbitrary <meta> tags, which we may not want to index).
> Patch to come shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1716) Adding norms, properties indexing
and writer.infoStream support to benchmark
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724016#action_12724016 ]
Shai Erera commented on LUCENE-1716:
------------------------------------
I was afraid of that ... I think we should just delete that section of the test. If you give an infoStream file which the OS cannot create, you'll get an exception. I see no reason to test for it.
Would you like me to update the patch, or can you just delete this part of the patch if you think it's ready to commit (the last lines of the patch - 587-597)?
> Adding norms, properties indexing and writer.infoStream support to benchmark
> ----------------------------------------------------------------------------
>
> Key: LUCENE-1716
> URL: https://issues.apache.org/jira/browse/LUCENE-1716
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1716.patch
>
>
> I would like to add the following support in benchmark:
> # Ability to specify whether norms should be stored in the index.
> # Ability to specify whether norms should be stored for the body field (assuming norms are usually stored for that field in real life applications, make it explicit)
> # Ability to specify an infoStream for IndexWriter
> # Ability to specify whether to index the properties returned on DocData (for content sources like TREC, these may include arbitrary <meta> tags, which we may not want to index).
> Patch to come shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org