[jira] [Commented] (HBASE-15491) Reuse byte buffers in AsyncRpcClient

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069891#comment-16069891 ] 

Hadoop QA commented on HBASE-15491:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m 11s{color} | {color:red} HBASE-15491 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-15491 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12794377/HBASE-15491-v1.patch |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7420/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Reuse byte buffers in AsyncRpcClient
> ------------------------------------
>
>                 Key: HBASE-15491
>                 URL: https://issues.apache.org/jira/browse/HBASE-15491
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>         Attachments: HBASE-15491-v1.patch
>
>
> IPCUtil.buildCellBlock is used by both server and client. Server provides BoundedByteBufferPool for buffers reuse, client code does not do that. This results in additional memory pressure on a client side, because buffers are allocated on every call to IPCUtil.buildCellBlock.
> My own local tests (with patch) show approximately 8-10% reduction in object allocation rate on a client side (with HBASE-15479 as well). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)