You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2003/06/17 00:01:58 UTC
Purify report for fs-test
Right, here's the list of problems found by Purify when running fs-test:
[W] UMR: Uninitialized memory read in svn_fs__bdb_open_uuids_table
Reading 1 byte from 0x0013f091 (1 byte at 0x0013f091 uninitialized)
Address 0x0013f091 points into a thread's stack
Thread ID: 0x4a0
Error location
svn_fs__bdb_open_uuids_table [uuids-table.c:78]
value.size = sizeof (buffer) - 1;
apr_uuid_get (&uuid);
=> apr_uuid_format (buffer, &uuid);
BDB_ERR (uuids->put (uuids, 0, &key, &value,
DB_APPEND | SVN_BDB_AUTO_COMMIT));
svn_fs_create_berkeley [fs.c:520]
svn_test__create_fs [fs-helpers.c:97]
reopen_trivial_transaction [fs-test.c:232]
do_test_num [svn_tests_main.c:153]
main [svn_tests_main.c:289]
mainCRTStartup [crtexe.obj]
[W] UMR: Uninitialized memory read in svn_fs__bdb_open_uuids_table {1 occurrence}
Reading 1 byte from 0x0013f091 (1 byte at 0x0013f091 uninitialized)
Address 0x0013f091 points into a thread's stack
Thread ID: 0x4a0
Error location
svn_fs__bdb_open_uuids_table [uuids-table.c:78]
value.size = sizeof (buffer) - 1;
apr_uuid_get (&uuid);
=> apr_uuid_format (buffer, &uuid);
BDB_ERR (uuids->put (uuids, 0, &key, &value,
DB_APPEND | SVN_BDB_AUTO_COMMIT));
svn_fs_create_berkeley [fs.c:520]
svn_test__create_fs [fs-helpers.c:97]
reopen_trivial_transaction [fs-test.c:232]
do_test_num [svn_tests_main.c:153]
main [svn_tests_main.c:289]
mainCRTStartup [crtexe.obj]
[W] UMC: Uninitialized memory copy in svn_fs__parse_representation_skel {22 occurrences}
Copying 1 byte from 0x018e7a8f (1 byte at 0x018e7a8f uninitialized)
Address 0x018e7a8f is 23 bytes into a 44 byte block at 0x018e7a78
Address 0x018e7a8f points to a malloc'd block in heap 0x003e0000
Thread ID: 0x4a0
Error location
svn_fs__parse_representation_skel [fs_skels.c:484]
{
memcpy (rep->checksum,
header_skel->children->next->next->children->next->data,
=> MD5_DIGESTSIZE);
}
else
{
svn_fs__bdb_read_rep [reps-table.c:100]
svn_fs__rep_contents_size [reps-strings.c:658]
svn_fs__rep_contents [reps-strings.c:716]
get_dir_entries [dag.c:441]
svn_fs__dag_dir_entries [dag.c:648]
dir_entry_id_from_node [dag.c:486]
svn_fs__dag_open [dag.c:1443]
open_path [tree.c:497]
txn_body_apply_textdelta [tree.c:3210]
Allocation location
malloc [MSVCRT.dll]
svn_fs__bdb_read_rep [reps-table.c:83]
svn_fs__rep_contents_size [reps-strings.c:658]
svn_fs__rep_contents [reps-strings.c:716]
get_dir_entries [dag.c:441]
svn_fs__dag_dir_entries [dag.c:648]
dir_entry_id_from_node [dag.c:486]
svn_fs__dag_open [dag.c:1443]
open_path [tree.c:497]
txn_body_apply_textdelta [tree.c:3210]
[W] UMR: Uninitialized memory read in implicit_atom {351 occurrences}
Reading 1 byte from 0x0241f1d2 (1 byte at 0x0241f1d2 uninitialized)
Address 0x0241f1d2 is 26 bytes into a 44 byte block at 0x0241f1b8
Address 0x0241f1d2 points to a malloc'd block in heap 0x003e0000
Thread ID: 0x4a0
Error location
implicit_atom [skel.c:207]
/* Find the end of the string. */
while (++data < end
&& skel_char_type[(unsigned char) *data] != type_space
=> && skel_char_type[(unsigned char) *data] != type_paren)
;
/* Allocate the skel representing this string. */
parse [skel.c:104]
list [skel.c:159]
parse [skel.c:100]
list [skel.c:159]
parse [skel.c:100]
list [skel.c:159]
parse [skel.c:100]
svn_fs__parse_skel [skel.c:79]
svn_fs__bdb_read_rep [reps-table.c:97]
Allocation location
malloc [MSVCRT.dll]
svn_fs__bdb_read_rep [reps-table.c:83]
svn_fs__rep_contents_size [reps-strings.c:658]
svn_fs__rep_contents [reps-strings.c:716]
get_dir_entries [dag.c:441]
svn_fs__dag_dir_entries [dag.c:648]
txn_body_dir_entries [tree.c:2505]
svn_fs__retry_txn [trail.c:132]
svn_fs_dir_entries [tree.c:2525]
check_entry [fs-test.c:1022]
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Purify report for fs-test
Posted by Branko Čibej <br...@xbc.nu>.
Philip Martin wrote:
>Branko ÄŒibej <br...@xbc.nu> writes:
>
>
>
>>Right, here's the list of problems found by Purify when running fs-test:
>>
>>[W] UMR: Uninitialized memory read in svn_fs__bdb_open_uuids_table
>> Reading 1 byte from 0x0013f091 (1 byte at 0x0013f091 uninitialized)
>> Address 0x0013f091 points into a thread's stack
>> Thread ID: 0x4a0
>> Error location
>> svn_fs__bdb_open_uuids_table [uuids-table.c:78]
>> value.size = sizeof (buffer) - 1;
>>
>> apr_uuid_get (&uuid);
>> => apr_uuid_format (buffer, &uuid);
>>
>>
>
>valgrind on Linux doesn't report anything here. How does 0x0013f091
>compare to buffer and &uuid? I note that APR's Windows UUID
>implementation is completely different from the Unix one, could the
>error be in inside apr_uuid_format?
>
That's quite possible, yes.
> It's hard to see what could be
>wrong with the line that calls apr_uuid_format.
>
Neither can I. Most probably an off-by-1 error in APR; but I'll
investigate when I get the time.
>
>
>
>> BDB_ERR (uuids->put (uuids, 0, &key, &value,
>> DB_APPEND | SVN_BDB_AUTO_COMMIT));
>> svn_fs_create_berkeley [fs.c:520]
>> svn_test__create_fs [fs-helpers.c:97]
>> reopen_trivial_transaction [fs-test.c:232]
>> do_test_num [svn_tests_main.c:153]
>> main [svn_tests_main.c:289]
>> mainCRTStartup [crtexe.obj]
>>
>>
>
>
>
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Purify report for fs-test
Posted by Philip Martin <ph...@codematters.co.uk>.
Branko Äibej <br...@xbc.nu> writes:
> Right, here's the list of problems found by Purify when running fs-test:
>
> [W] UMR: Uninitialized memory read in svn_fs__bdb_open_uuids_table
> Reading 1 byte from 0x0013f091 (1 byte at 0x0013f091 uninitialized)
> Address 0x0013f091 points into a thread's stack
> Thread ID: 0x4a0
> Error location
> svn_fs__bdb_open_uuids_table [uuids-table.c:78]
> value.size = sizeof (buffer) - 1;
>
> apr_uuid_get (&uuid);
> => apr_uuid_format (buffer, &uuid);
valgrind on Linux doesn't report anything here. How does 0x0013f091
compare to buffer and &uuid? I note that APR's Windows UUID
implementation is completely different from the Unix one, could the
error be in inside apr_uuid_format? It's hard to see what could be
wrong with the line that calls apr_uuid_format.
> BDB_ERR (uuids->put (uuids, 0, &key, &value,
> DB_APPEND | SVN_BDB_AUTO_COMMIT));
> svn_fs_create_berkeley [fs.c:520]
> svn_test__create_fs [fs-helpers.c:97]
> reopen_trivial_transaction [fs-test.c:232]
> do_test_num [svn_tests_main.c:153]
> main [svn_tests_main.c:289]
> mainCRTStartup [crtexe.obj]
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org