You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/11 19:16:23 UTC
Review Request 46038: Added recommended production config to the docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Added recommended production config to the docs.
Diffs
-----
docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5
Diff: https://reviews.apache.org/r/46038/diff/
Testing
-------
Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 46038: Added recommended production config to the
docs.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/#review128181
-----------------------------------------------------------
Providing recommended values without justifying why they are "recommended" seems a bit problematic to me, because it encourages people to blindly copy the recommended configuration without understanding whether it is applicable for their environment. What do you think about adding an "explanation" column with a short justification for why a particular value is recommended?
- Neil Conway
On April 11, 2016, 5:16 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46038/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 5:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added recommended production config to the docs.
>
>
> Diffs
> -----
>
> docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5
>
> Diff: https://reviews.apache.org/r/46038/diff/
>
>
> Testing
> -------
>
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46038: Added recommended production config to the
docs.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/#review128428
-----------------------------------------------------------
docs/operational-guide.md (line 8)
<https://reviews.apache.org/r/46038/#comment191856>
Just a question does it make sense to add more detail info here? Such as `Why do I need those paramteres in production and how can those paramters help?`
docs/operational-guide.md (line 93)
<https://reviews.apache.org/r/46038/#comment191853>
2 spaces
- Guangya Liu
On 四月 11, 2016, 10:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46038/
> -----------------------------------------------------------
>
> (Updated 四月 11, 2016, 10:57 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provided information in the operational guide on what
> configuration options are advisable for production
> environments.
>
>
> Diffs
> -----
>
> docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5
>
> Diff: https://reviews.apache.org/r/46038/diff/
>
>
> Testing
> -------
>
> Viewed with the Mesos website container:
> https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46038: Added recommended production config to the
docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/
-----------------------------------------------------------
(Updated April 11, 2016, 10:57 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Repository: mesos
Description
-------
Provided information in the operational guide on what
configuration options are advisable for production
environments.
Diffs
-----
docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5
Diff: https://reviews.apache.org/r/46038/diff/
Testing
-------
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 46038: Added recommended production config to the
docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/
-----------------------------------------------------------
(Updated April 11, 2016, 9:10 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description (updated)
-------
Provided information in the operational guide on what
configuration options are advisable for production
environments.
Diffs
-----
docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5
Diff: https://reviews.apache.org/r/46038/diff/
Testing
-------
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 46038: Added recommended production config to the
docs.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/
-----------------------------------------------------------
(Updated April 11, 2016, 9:05 p.m.)
Review request for mesos, Jie Yu and Neil Conway.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Added recommended production config to the docs.
Diffs
-----
docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5
Diff: https://reviews.apache.org/r/46038/diff/
Testing (updated)
-------
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 46038: Added recommended production config to the
docs.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/#review128238
-----------------------------------------------------------
Bad patch!
Reviews applied: [46038, 45562, 46004, 46005, 46003]
Failed command: ./support/apply-review.sh -n -r 46003
Error:
2016-04-11 20:26:09 URL:https://reviews.apache.org/r/46003/diff/raw/ [6052/6052] -> "46003.patch" [1]
Total errors found: 0
Checking 7 files
Error: No line in the commit message summary may exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/12463/console
- Mesos ReviewBot
On April 11, 2016, 5:16 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46038/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 5:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Neil Conway.
>
>
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added recommended production config to the docs.
>
>
> Diffs
> -----
>
> docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5
>
> Diff: https://reviews.apache.org/r/46038/diff/
>
>
> Testing
> -------
>
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>