You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "chinmayb (via GitHub)" <gi...@apache.org> on 2024/05/29 13:37:25 UTC
Re: [PR] [fix] Reconnection logic and Backoff policy doesn't work correctly [pulsar-client-go]
chinmayb commented on code in PR #1197:
URL: https://github.com/apache/pulsar-client-go/pull/1197#discussion_r1618906341
##########
pulsar/consumer_partition.go:
##########
@@ -1673,11 +1680,8 @@ func (pc *partitionConsumer) reconnectToBroker() {
return
}
- if pc.options.backoffPolicy == nil {
- delayReconnectTime = defaultBackoff.Next()
- } else {
- delayReconnectTime = pc.options.backoffPolicy.Next()
- }
+ delayReconnectTime = bo.Next()
+ totalDelayReconnectTime += delayReconnectTime
Review Comment:
We also need to reset the `delayReconnectTime` once connected after several retries in 1692.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org