[GitHub] [iotdb] Beyyes commented on a diff in pull request #7670: [IOTDB-4616] Support serialization and deserialization for confignode standalone mode

[GitBox <gi...@apache.org>]

Beyyes commented on code in PR #7670:
URL: https://github.com/apache/iotdb/pull/7670#discussion_r1001334635


##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java:
##########
@@ -35,7 +35,7 @@ public class ConfigNodeConfig {
   private volatile int configNodeId = -1;
 
   /** could set ip or hostname */
-  private String internalAddress = "0.0.0.0";
+  private String internalAddress = "127.0.0.1";

Review Comment:
   remove it, 
   add conf in iotdb-confignode.properties



##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java:
##########
@@ -50,7 +50,7 @@ public class ConfigNodeConfig {
   private int partitionRegionId = 0;
 
   /** ConfigNodeGroup consensus protocol */
-  private String configNodeConsensusProtocolClass = ConsensusFactory.RatisConsensus;
+  private String configNodeConsensusProtocolClass = ConsensusFactory.StandAloneConsensus;

Review Comment:
   Ratis as default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org