[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593793#comment-16593793 ] 

ASF GitHub Bot commented on FLINK-8686:
---------------------------------------

twalthr opened a new pull request #6621:  [FLINK-8686] [sql-client] Limit result size for prototyping modes
URL: https://github.com/apache/flink/pull/6621
 
 
   ## What is the purpose of the change
   
   This PR aims to make the SQL Client more robust by limiting the result size for both changelog and table result modes. In changelog mode the responsiveness of the CLI is the limiting factor. In table mode only the main memory is the limiting factor and the configurable maximum row count.
   
   This PR is built on top of FLINK-10192.
   
   ## Brief change log
   
   - Add a hard limit for changelog mode (1000 rows)
   - Add a configurable limit for table mode
   
   ## Verifying this change
   
   - Added test `LocalExecutorITCase#testStreamQueryExecutionLimitedTable`
   - Added test `MaterializedCollectStreamResultTest#testLimitedSnapshot`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve basic embedded SQL client 
> ----------------------------------
>
>                 Key: FLINK-8686
>                 URL: https://issues.apache.org/jira/browse/FLINK-8686
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> This issue describes follow-up issues that should be fixes in order to make the SQL client more stable:
>  - -Add more tests for executor-
>  - Configure JVM heap size
>  - Limit changelog and table buffers
>  - -"The input is invalid please check it again." => add allowed range-
>  - Load dependencies recursively
>  - Clean up results in result store
>  - -Improve error message for unsupported batch queries-
>  - -Add more logging instead swallowing exceptions-
>  - -List properties in error message about missing TS factory sorted by name-
>  - Add command to show loaded TS factories and their required propeties
>  - Add command to reload configuration from files (no need to restart client)
>  - Improve error message in case of invalid json-schema (right now: {{java.lang.IllegalArgumentException: No type could be found in node:<root>}}
>  - -Add switch to show full stacktraces of exceptions- solved by logging
>  - Give error message when setting unknown parameters {{result-mode=changelog}} does not give an error but should be {{execution.result-mode=changelog}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)