You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/01 13:45:31 UTC

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1149: refactor: move VERSION to src/folder #1148

tisonkun commented on PR #1149:
URL: https://github.com/apache/incubator-kvrocks/pull/1149#issuecomment-1333792008

   I'd prefer to write `VERSION.txt` instead of `.VERSION`. There's no reason for the VERSION file to be hidden.
   
   @PragmaTwice for https://github.com/apache/incubator-kvrocks/issues/1148#issuecomment-1333696239, I'd say that `version.h.in` is not a typical source file also, but we host all source files and meta source files (that generates source files under `src`). You can think of proto definitions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org