You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mpjlu <gi...@git.apache.org> on 2017/12/12 03:13:55 UTC

[GitHub] spark issue #18624: [SPARK-21389][ML][MLLIB] Optimize ALS recommendForAll by...

Github user mpjlu commented on the issue:

    https://github.com/apache/spark/pull/18624
  
    Hi @holdenk, this is the PR we have discussed in Strata conference. 
    ![matrix multiply-topk-strata](https://user-images.githubusercontent.com/13826327/33865337-4e761a4a-df2c-11e7-8eed-1763429a78ea.jpg)
    
    I have thought about the code again, for the performance, we can continue to optimize the code. Because we can merge the block matrices before shuffle. 
    For only code simplification, I didn't get a good method. 
    Any change needs many tests about the performance, and now I am in a DL team, and I will not have the test environment soon.
    I will be glad if anyone wants to continue this work.
    Thanks.  


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org