You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Sergey Shelukhin (JIRA)" <ji...@apache.org> on 2018/04/02 21:31:00 UTC
[jira] [Commented] (HIVE-17647) DDLTask.generateAddMmTasks(Table
tbl) should not start transactions
[ https://issues.apache.org/jira/browse/HIVE-17647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423164#comment-16423164 ]
Sergey Shelukhin commented on HIVE-17647:
-----------------------------------------
We will dbl check the code to open txns when necessary, and replace else with throw (in case we miss smth)
> DDLTask.generateAddMmTasks(Table tbl) should not start transactions
> -------------------------------------------------------------------
>
> Key: HIVE-17647
> URL: https://issues.apache.org/jira/browse/HIVE-17647
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
> Reporter: Eugene Koifman
> Priority: Major
> Labels: mm-gap-2
>
> This method has
> {noformat}
> if (txnManager.isTxnOpen()) {
> mmWriteId = txnManager.getCurrentTxnId();
> } else {
> mmWriteId = txnManager.openTxn(new Context(conf), conf.getUser());
> txnManager.commitTxn();
> }
> {noformat}
> this should throw if there is no open transaction. It should never open one.
> In general the logic seems suspect. Looks like the intent is to move all existing files into a delta_x_x/ when a plain table is converted to MM table. This seems like something that needs to be done from under an Exclusive lock to prevent concurrent Insert operations writing data under table/partition root. But this is too late to acquire locks which should be done from the Driver.acquireLocks() (or else have deadlock detector since acquiring them here would bread all-or-nothing lock acquisition semantics currently required w/o deadlock detector)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)