[GitHub] [trafficcontrol] rob05c opened a new issue #4459: Prohibit Non-ASCII Characters in Parameters, Delivery Service, Server Fields

[GitBox <gi...@apache.org>]

rob05c opened a new issue #4459: Prohibit Non-ASCII Characters in Parameters, Delivery Service, Server Fields
URL: https://github.com/apache/trafficcontrol/issues/4459
 
 
   Apache Traffic Server does not support Unicode in config files. We should add constraints in both the Portal UI and the API prohibiting non-ASCII characters in all Parameter Names, Values, ConfigFile; and all Delivery Service and Server fields which end up in a ATS config file.
   
   I can't think of any reason to need a non-ASCII character in any Parameters which _don't_ end up in an ATS config file, and the vast majority do.
   
   We can't add a DB constraint or prohibit existing values, or we could break some user with them. But we can and should prohibit new values.
   
   This is especially helpful for debugging and preventing errors with nonprinting whitespace and invisible characters which accidentally end up in these fields and files.
   
   ## I'm submitting a ...
   <!-- (check all that apply with "[x]") -->
   <!--- security vulnerability (STOP!! - see above)-->
   - [ ] bug report
   - [x] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other <!--(Please do not submit support requests here - see above)-->
   
   ## Traffic Control components affected ...
   <!-- (check all that apply with "[x]") -->
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [x] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   Unicode is allowed in TO fields which end up in ATS configs.
   
   ## Expected / new behavior:
   Unicode should not be allowed. Field should fail to validate, and users should get an error message.
   
   Validation should exist in both Portal and API. Multiple failsafes prevent failure in complex systems.
   
   ## Minimal reproduction of the problem with instructions:
   Add high unicode character in a Parameter value. It works. It should not work.
   
   ## Anything else:
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services