You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "pgj (via GitHub)" <gi...@apache.org> on 2023/06/30 20:11:44 UTC

[GitHub] [couchdb] pgj opened a new pull request, #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

pgj opened a new pull request, #4659:
URL: https://github.com/apache/couchdb/pull/4659

   Indexable fields from selectors are not de-duplicated when collected.  This means that every time when the same field is referenced in the selector, it will be added to the result.  This does not sound like a good practice in general, but addressing it would also make the implementation consistent with that of the view indexes.
   
   In addition to all these, the change could help with exposing this information more cleanly when guiding the user in composing better queries.
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] rnewson commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1269428870


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   the docs for ordsets says `Elements are ordered according to the Erlang term order.`. If the intent is to preserve the original order, neither ordsets or usort/ukeysort seems to be right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1262753417


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   `lists:uniq/1` could make a good candidate but that requires OTP 25.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1262750357


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   Oh, now I remember: the reason for choosing `ordsets` is to maintain the original order of the fields.  A side-effect of `lists:usort/1` is that the elements will be sorted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] rnewson commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1276147572


##########
src/couch/src/couch_lists.erl:
##########
@@ -0,0 +1,46 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%
+%   http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
+
+-module(couch_lists).
+
+-export([uniq/1]).
+
+%% uniq/1: return a new list with the unique elements of the given list
+
+-spec uniq(List1) -> List2 when
+    List1 :: [T],
+    List2 :: [T],
+    T :: term().
+
+-ifdef(OTP_RELEASE).
+-if((?OTP_RELEASE) >= 25).
+-define(HAS_LISTS_UNIQ, true).

Review Comment:
   `?OTP_RELEASE` was introduced in Erlang/OTP 21 and our minimum version is now 23, so we don't need to test for it. I see recent commits where we've removed the extra `-ifdef(OTP_RELEASE)` check. I think remove that and seeing if we can simplify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1269475088


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   Oh, this property of Erlang `ordsets` has escaped my attention.  If that is case, you are right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1272427507


##########
src/couch/src/couch_util.erl:
##########
@@ -870,3 +871,19 @@ remove_sensitive_data(KVList) ->
     KVList1 = lists:keyreplace(<<"password">>, 1, KVList, {<<"password">>, <<"****">>}),
     % some KVList entries are atoms, so test fo this too
     lists:keyreplace(password, 1, KVList1, {password, <<"****">>}).
+
+% Alternative to `lists:uniq/1` until OTP 26 becomes the oldest
+% supported version.
+-spec nub(list()) -> list().
+nub(L) ->
+    nub_int(L, sets:new()).

Review Comment:
   Since we support OTP 24+ we can use a generally faster version of `sets` with `sets:new([{version, 2}]).`
   
   https://www.erlang.org/doc/man/sets.html
   
   It might not matter for indexable_fields as much but since it's in `couch_util` we might end up using some place where it might make a difference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1272649552


##########
src/couch/src/couch_util.erl:
##########
@@ -870,3 +871,19 @@ remove_sensitive_data(KVList) ->
     KVList1 = lists:keyreplace(<<"password">>, 1, KVList, {<<"password">>, <<"****">>}),
     % some KVList entries are atoms, so test fo this too
     lists:keyreplace(password, 1, KVList1, {password, <<"****">>}).
+
+% Alternative to `lists:uniq/1` until OTP 26 becomes the oldest
+% supported version.
+-spec nub(list()) -> list().
+nub(L) ->
+    nub_int(L, sets:new()).

Review Comment:
   Yes, I agree.  Thanks for the comment!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1272427507


##########
src/couch/src/couch_util.erl:
##########
@@ -870,3 +871,19 @@ remove_sensitive_data(KVList) ->
     KVList1 = lists:keyreplace(<<"password">>, 1, KVList, {<<"password">>, <<"****">>}),
     % some KVList entries are atoms, so test fo this too
     lists:keyreplace(password, 1, KVList1, {password, <<"****">>}).
+
+% Alternative to `lists:uniq/1` until OTP 26 becomes the oldest
+% supported version.
+-spec nub(list()) -> list().
+nub(L) ->
+    nub_int(L, sets:new()).

Review Comment:
   Since we support OTP 24+ we can use a generally faster version of `sets` with `sets:new([{version, 2}]).`
   
   https://www.erlang.org/doc/man/sets.html
   
   It might not matter for indexable_fields as much but since it's in `couch_util` we might end up using it some place where it might make a difference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1269605887


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   I have pushed a version that uses a version of `lists:uniq/1` to deduplicate the collected elements at the end.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1276109443


##########
src/couch/src/couch_lists.erl:
##########
@@ -0,0 +1,46 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%
+%   http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
+
+-module(couch_lists).
+
+-export([uniq/1]).
+
+%% uniq/1: return a new list with the unique elements of the given list
+
+-spec uniq(List1) -> List2 when
+    List1 :: [T],
+    List2 :: [T],
+    T :: term().
+
+-ifdef(OTP_RELEASE).
+-if((?OTP_RELEASE) >= 25).
+-define(HAS_LISTS_UNIQ, true).

Review Comment:
   These are two nested `if`s where each could have its own `else` branches.  This creates 3 possible branches: 1 for using `lists:uniq/1` directly and 2 for using its imported definition (no `OTP_RELEASE` defined or it is defined but its value is lesser than `25`).  I wanted to avoid the code duplication for these latter ones.
   
   I know `HAS_LISTS_UNIQ` may look `autoconf`ish but it works nicely.  For what it is worth, I was inspired by [`mochiweb`](https://github.com/mochi/mochiweb/blob/073349423408e4bae08c90f8d16fee5317e45263/examples/example_project/src/example_project_web.erl#L22-L32).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1276203538


##########
src/couch/src/couch_lists.erl:
##########
@@ -0,0 +1,46 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%
+%   http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
+
+-module(couch_lists).
+
+-export([uniq/1]).
+
+%% uniq/1: return a new list with the unique elements of the given list
+
+-spec uniq(List1) -> List2 when
+    List1 :: [T],
+    List2 :: [T],
+    T :: term().
+
+-ifdef(OTP_RELEASE).
+-if((?OTP_RELEASE) >= 25).
+-define(HAS_LISTS_UNIQ, true).

Review Comment:
   Sure, that is also an option for me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] rnewson commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1276093492


##########
src/couch/src/couch_lists.erl:
##########
@@ -0,0 +1,46 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%
+%   http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
+
+-module(couch_lists).
+
+-export([uniq/1]).
+
+%% uniq/1: return a new list with the unique elements of the given list
+
+-spec uniq(List1) -> List2 when
+    List1 :: [T],
+    List2 :: [T],
+    T :: term().
+
+-ifdef(OTP_RELEASE).
+-if((?OTP_RELEASE) >= 25).
+-define(HAS_LISTS_UNIQ, true).

Review Comment:
   why not put the code here (and the impl in an else)? the extra set of pragmas don't add anything afaict.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] rnewson commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1262242037


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   is `ordsets` throughout the function better/faster than just a `lists:ukeysort` at the end?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1262734010


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   If I recall correctly, this method was chosen based on a discussion on the topic on Slack.  But I might have misunderstood that.  Either way it happened, I have done some simple measurements to see which approach is faster.  Although I believe you meant `lists:usort/1`?  The `lists:ukeysort/2` function seems to work with tuples only.
   
   ```console
   > Xs = lists:map(fun(_X) -> rand:uniform(1000) end, lists:seq(1, 10_000)).
   [153,53,32,94,647,739,807,484,695,434,934,437,149,888,853,
    251,639,101,838,404,236,68,187,350,467,162,1000,775,930|...]
   > element(1, timer:tc(fun() -> ordsets:to_list(lists:foldr(fun(X, Acc) -> ordsets:add_element(X, Acc) end, ordsets:new(), Xs)) end)) / 1000.
   63.81
   > > element(1, timer:tc(fun() -> lists:usort(lists:foldr(fun(X, Acc) -> [X | Acc] end, [], Xs)) end)) / 1000.
   11.752
   ```
   
   The results suggest that the use of `ordsets` is not justified here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] pgj commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1262734010


##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
 
 indexable_fields(Selector) ->
     TupleTree = mango_selector_text:convert([], Selector),
-    indexable_fields([], TupleTree).
+    ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).

Review Comment:
   If I recall correctly, this method was chosen based on a discussion on the topic on Slack.  But I might have misunderstood that.  Either way it happened, I have done some simple measurements to see which approach is faster.  Although I believe you meant `lists:usort/1`?  The `lists:ukeysort/2` function seems to work with tuples only.
   
   ```console
   > Xs = lists:map(fun(_X) -> rand:uniform(1000) end, lists:seq(1, 10_000)).
   [153,53,32,94,647,739,807,484,695,434,934,437,149,888,853,
    251,639,101,838,404,236,68,187,350,467,162,1000,775,930|...]
   > element(1, timer:tc(fun() -> ordsets:to_list(lists:foldr(fun(X, Acc) -> ordsets:add_element(X, Acc) end, ordsets:new(), Xs)) end)) / 1000.
   63.81
   > element(1, timer:tc(fun() -> lists:usort(lists:foldr(fun(X, Acc) -> [X | Acc] end, [], Xs)) end)) / 1000.
   11.752
   ```
   
   The results suggest that the use of `ordsets` is not justified here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva commented on a diff in pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1272427507


##########
src/couch/src/couch_util.erl:
##########
@@ -870,3 +871,19 @@ remove_sensitive_data(KVList) ->
     KVList1 = lists:keyreplace(<<"password">>, 1, KVList, {<<"password">>, <<"****">>}),
     % some KVList entries are atoms, so test fo this too
     lists:keyreplace(password, 1, KVList1, {password, <<"****">>}).
+
+% Alternative to `lists:uniq/1` until OTP 26 becomes the oldest
+% supported version.
+-spec nub(list()) -> list().
+nub(L) ->
+    nub_int(L, sets:new()).

Review Comment:
   Since we support OTP 24+ we can use a bit of a faster version of sets with `sets:new([{version, 2}]).`
   
   https://www.erlang.org/doc/man/sets.html
   
   It might not matter for indexable_fields as much but since it's in `couch_util` we might end up using some place where it might make a difference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva merged pull request #4659: fix(`mango`): remove duplicate elements from `indexable_fields/1` results

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #4659:
URL: https://github.com/apache/couchdb/pull/4659


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org