[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #9866: [IOTDB-5885] Add exception when measurement already exists in schema template

["MarcosZyk (via GitHub)" <gi...@apache.org>]

MarcosZyk commented on code in PR #9866:
URL: https://github.com/apache/iotdb/pull/9866#discussion_r1194861128


##########
server/src/main/java/org/apache/iotdb/db/metadata/template/alter/TemplateExtendInfo.java:
##########
@@ -102,6 +103,41 @@ public void addMeasurement(
     compressors.add(compressionType);
   }
 
+  public List<String> removeMeasurements(Set<String> targetMeasurementSet) {

Review Comment:
   Fixed.



##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java:
##########
@@ -773,16 +773,19 @@ public synchronized TSStatus extendSchemaTemplate(TemplateExtendInfo templateExt
     }
 
     Template template = resp.getTemplateList().get(0);
-    boolean needExtend = false;
-    for (String measurement : templateExtendInfo.getMeasurements()) {
-      if (!template.hasSchema(measurement)) {
-        needExtend = true;
-        break;
-      }
-    }
+    List<String> removedMeasurements =

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org