You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/09 08:55:13 UTC
[GitHub] [incubator-echarts] zhangzhonghe opened a new pull request #12595: fix(splitLine): change algorithm. (#12293)
zhangzhonghe opened a new pull request #12595:
URL: https://github.com/apache/incubator-echarts/pull/12595
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
重写了偏移刻度线的算法，以修复#12293的问题。
### Fixed issues
<!--
- #xxxx: ...
-->
#12293: 分割线不以用户期望的方式渲染。
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
分割线总是会在X轴的最后一个刻度上渲染。
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
重新写了相关的算法。
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
实际效果可以看[这里](https://zhangzhonghe.github.io/echarts-issue-12293-test/)。
[这里](https://github.com/zhangzhonghe/echarts-issue-12293-test)是代码地址。
## Others
### Merging options
- [x] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] zhangzhonghe edited a comment on pull request #12595: fix(splitLine): change algorithm. (#12293)
Posted by GitBox <gi...@apache.org>.
zhangzhonghe edited a comment on pull request #12595:
URL: https://github.com/apache/incubator-echarts/pull/12595#issuecomment-626142538
@susiwen8 yes，i will do it later!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] zhangzhonghe commented on pull request #12595: fix(splitLine): change algorithm. (#12293)
Posted by GitBox <gi...@apache.org>.
zhangzhonghe commented on pull request #12595:
URL: https://github.com/apache/incubator-echarts/pull/12595#issuecomment-626142538
@susiwen8 not yet，i will do it later!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] zhangzhonghe commented on pull request #12595: fix(splitLine): change algorithm. (#12293)
Posted by GitBox <gi...@apache.org>.
zhangzhonghe commented on pull request #12595:
URL: https://github.com/apache/incubator-echarts/pull/12595#issuecomment-626270290
@susiwen8 I made a test, please review.🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12595: fix(splitLine): change algorithm. (#12293)
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12595:
URL: https://github.com/apache/incubator-echarts/pull/12595#issuecomment-626141878
Could you add a test for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12595: fix(splitLine): change algorithm. (#12293)
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12595:
URL: https://github.com/apache/incubator-echarts/pull/12595#issuecomment-626131884
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org