You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/11 06:59:10 UTC

[GitHub] [iceberg] jackye1995 commented on pull request #6559: Core: View core parser implementations

jackye1995 commented on PR #6559:
URL: https://github.com/apache/iceberg/pull/6559#issuecomment-1378314697

   I am trying see if we can break this further so that it's easier to review for a broader audience. There are some implementations of the basic interface, such as `BaseViewVersion`, `BaseSQLViewRepresentation`, `BaseViewHistoryEntry`, can we have a PR to first add these objects and their corresponding parsers in 3 small PRs? This would help the reviewers, also help to add tests for each feature we implement. Otherwise there is currently just 1 test for the entire view metadata.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org