[jira] [Commented] (CAMEL-9274) StreamCache does not work correctly with MarshalProcessor and pretty much all DataFormats

["Claus Ibsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991602#comment-14991602 ] 

Claus Ibsen commented on CAMEL-9274:
------------------------------------

Thanks for the v2 patch. You are welcome to work on the other data formats so we can get them to use the builder also.

> StreamCache does not work correctly with MarshalProcessor and pretty much all DataFormats
> -----------------------------------------------------------------------------------------
>
>                 Key: CAMEL-9274
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9274
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.16.0
>            Reporter: Aaron Whiteside
>            Assignee: Claus Ibsen
>             Fix For: 2.17.0
>
>         Attachments: CAMEL_9274.patch, CAMEL_9274_v2.patch
>
>
> StreamCache does not work correctly with MarshalProcessor and pretty much all DataFormats
> # Documentation states that stream caching can be turned on, on a per route basis. The places were we actually try and utilize stream caching only checks if the global option is turned on (MarshalProcessor + PGPKeyAccessDataFormat, I can't find any other meaningful attempts to use stream caching anywhere else) not the per route setting.
> # Secondly, if we ignore the first problem, only one data formatter tries to use stream caching for unmarshaling: PGPKeyAccessDataFormat. If you try and unzip a large zip file it's contents will be decompressed into memory. The same goes for any other large data formatter conversion (unmarshaling, only).
> Attached is a patch that corrects the first problem and part of the second problem (ZipFileDataFormat, ZipDataFormat and PGPKeyAccessDataFormat).
> A separate issue should probably be opened to fix all the remaining DataFormat implementation to support Stream Caching.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)