[GitHub] [iceberg] chenjunjiedada commented on pull request #974: Add unit tests for sequence number

[GitBox <gi...@apache.org>]

chenjunjiedada commented on pull request #974:
URL: https://github.com/apache/iceberg/pull/974#issuecomment-637223712


   @rdblue, I 'm going to complement the unit tests in some following PRs for sequence number as you mentioned in sync-up meeting minutes. Do you want the assertions to follow this as well?
   
   
   > All the metadata for every change should be validated:
   Each operation that produces a sequence number should assert the number of changed manifests
   Each changed manifest should have its entries validated, including file status, snapshot id, and sequence number
   Each operation should validate the lastSequenceNumber in table metadata
   Operations that do not produce a sequence number should validate that the sequence number did not change using the last sequence number in table metadata.
   
   Are assertions in the latest change of this commit too much? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org