You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/03/04 19:15:13 UTC
Review Request 31734: Fixed a regression of replicated log logging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31734/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Kapil Arya.
Bugs: MESOS-2447
https://issues.apache.org/jira/browse/MESOS-2447
Repository: mesos
Description
-------
Fixed a regression of replicated log logging.
Diffs
-----
src/messages/log.hpp b9c1dabce1f2755d7757b6da862457aff733f152
src/messages/messages.hpp 4333b90310d59f4b9b1c628b11197b3aaa9b1508
Diff: https://reviews.apache.org/r/31734/diff/
Testing
-------
Manually verify the logging.
Thanks,
Jie Yu
Re: Review Request 31734: Fixed a regression of replicated log
logging.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31734/#review75215
-----------------------------------------------------------
Ship it!
src/messages/log.hpp
<https://reviews.apache.org/r/31734/#comment122181>
Looks like just <ostream> will suffice?
src/messages/messages.hpp
<https://reviews.apache.org/r/31734/#comment122180>
Do you still need this include?
src/messages/messages.hpp
<https://reviews.apache.org/r/31734/#comment122182>
Not yours, but looks like we need an <ostream> include.
- Ben Mahler
On March 4, 2015, 7:06 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31734/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 7:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Kapil Arya.
>
>
> Bugs: MESOS-2447
> https://issues.apache.org/jira/browse/MESOS-2447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a regression of replicated log logging.
>
>
> Diffs
> -----
>
> src/messages/log.hpp b9c1dabce1f2755d7757b6da862457aff733f152
> src/messages/messages.hpp 4333b90310d59f4b9b1c628b11197b3aaa9b1508
>
> Diff: https://reviews.apache.org/r/31734/diff/
>
>
> Testing
> -------
>
> Manually verify the logging.
>
> Before:
> Replica learned 2 action at position 3
>
> After:
> Replica learned APPEND action at position 3
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 31734: Fixed a regression of replicated log
logging.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31734/
-----------------------------------------------------------
(Updated March 4, 2015, 7:06 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Kapil Arya.
Bugs: MESOS-2447
https://issues.apache.org/jira/browse/MESOS-2447
Repository: mesos
Description
-------
Fixed a regression of replicated log logging.
Diffs
-----
src/messages/log.hpp b9c1dabce1f2755d7757b6da862457aff733f152
src/messages/messages.hpp 4333b90310d59f4b9b1c628b11197b3aaa9b1508
Diff: https://reviews.apache.org/r/31734/diff/
Testing (updated)
-------
Manually verify the logging.
Before:
Replica learned 2 action at position 3
After:
Replica learned APPEND action at position 3
Thanks,
Jie Yu
Re: Review Request 31734: Fixed a regression of replicated log
logging.
Posted by Jie Yu <yu...@gmail.com>.
> On March 4, 2015, 6:50 p.m., Niklas Nielsen wrote:
> > Can you put in the before and after log lines in the RR description? :)
Done. Also in the ticket.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31734/#review75208
-----------------------------------------------------------
On March 4, 2015, 7:06 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31734/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 7:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Kapil Arya.
>
>
> Bugs: MESOS-2447
> https://issues.apache.org/jira/browse/MESOS-2447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a regression of replicated log logging.
>
>
> Diffs
> -----
>
> src/messages/log.hpp b9c1dabce1f2755d7757b6da862457aff733f152
> src/messages/messages.hpp 4333b90310d59f4b9b1c628b11197b3aaa9b1508
>
> Diff: https://reviews.apache.org/r/31734/diff/
>
>
> Testing
> -------
>
> Manually verify the logging.
>
> Before:
> Replica learned 2 action at position 3
>
> After:
> Replica learned APPEND action at position 3
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 31734: Fixed a regression of replicated log
logging.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31734/#review75208
-----------------------------------------------------------
Ship it!
Can you put in the before and after log lines in the RR description? :)
- Niklas Nielsen
On March 4, 2015, 10:15 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31734/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 10:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Kapil Arya.
>
>
> Bugs: MESOS-2447
> https://issues.apache.org/jira/browse/MESOS-2447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a regression of replicated log logging.
>
>
> Diffs
> -----
>
> src/messages/log.hpp b9c1dabce1f2755d7757b6da862457aff733f152
> src/messages/messages.hpp 4333b90310d59f4b9b1c628b11197b3aaa9b1508
>
> Diff: https://reviews.apache.org/r/31734/diff/
>
>
> Testing
> -------
>
> Manually verify the logging.
>
>
> Thanks,
>
> Jie Yu
>
>