You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "humkum (via GitHub)" <gi...@apache.org> on 2023/05/15 07:36:49 UTC

[GitHub] [rocketmq] humkum commented on a diff in pull request #6746: [ISSUE #6747]feat:add INNER_MULTI_DISPATCH check, can not contains '/' path separator

humkum commented on code in PR #6746:
URL: https://github.com/apache/rocketmq/pull/6746#discussion_r1193440574


##########
common/src/main/java/org/apache/rocketmq/common/MixAll.java:
##########
@@ -96,6 +96,7 @@ public class MixAll {
     public static final String REPLY_MESSAGE_FLAG = "reply";
     public static final String LMQ_PREFIX = "%LMQ%";
     public static final String MULTI_DISPATCH_QUEUE_SPLITTER = ",";
+    public static final String PATH_SEPARATOR = "/";

Review Comment:
   > Should we consider other operating systems, such as Windows, whose path delimiter is \?
   
   Yes.I had changed the pr to contains these situations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org