[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #94: Adds whitelist for custom serializer of classes in pekko package

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #94:
URL: https://github.com/apache/incubator-pekko/pull/94#discussion_r1087816708


##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -457,8 +453,12 @@ class Serialization(val system: ExtendedActorSystem) extends Extension {
     }
   }
 
-  private def warnUnexpectedNonAkkaSerializer(clazz: Class[_], ser: Serializer): Boolean = {
-    if (clazz.getName.startsWith("org.apache.pekko.") && !ser.getClass.getName.startsWith("org.apache.pekko.")) {
+  @nowarn("msg=deprecated")
+  private def warnUnexpectedNonPekkoSerializer(clazz: Class[_], ser: Serializer): Boolean = {
+    import scala.collection.JavaConverters._ // switch to scala.jdk.CollectionConverters once Scala 2.12 support is dropped
+    if (clazz.getName.startsWith("org.apache.pekko.") && !ser.getClass.getName.startsWith("org.apache.pekko.") &&

Review Comment:
   This might make sense in a separate PR, at least when I was renaming the package to `org.apache.pekko` there were a few cases where package names was being checked `clazz.getName`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org