[jira] [Commented] (PIG-2928) Fix e2e test failures in trunk: FilterBoolean_23/24

["Rohini Palaniswamy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462470#comment-13462470 ] 

Rohini Palaniswamy commented on PIG-2928:
-----------------------------------------

+1 non-binding. Seems to be accidental reversion looking at the PIG-1314 patch. Anyways would be good to get confirmation from [~zjshen]
                
> Fix e2e test failures in trunk: FilterBoolean_23/24
> ---------------------------------------------------
>
>                 Key: PIG-2928
>                 URL: https://issues.apache.org/jira/browse/PIG-2928
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: 0.10.0
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>             Fix For: 0.11
>
>         Attachments: PIG-2928.patch
>
>
> To reproduce the failure, please run
> {code}
> ant -Dhadoopversion=20 ... -Dtest-e2e-deploy-local
> ant -Dhadoopversion=20 ... -Dtest-e2e-local -Dtests.to.run="-t FilterBoolean_23"
> {code}
> This is a regression from PIG-1314.
> PIG-1314 reverted the following change made by PIG-2593 that had made it possible to filter by a boolean value.
> {code}
> --- src/org/apache/pig/parser/QueryParser.g
> +++ src/org/apache/pig/parser/QueryParser.g
> @@ -391,13 +391,16 @@ or_cond : and_cond  ( OR^ and_cond )*
>  and_cond : unary_cond ( AND^ unary_cond )*
>  ;
>  
> -unary_cond : LEFT_PAREN! cond RIGHT_PAREN!
> -           | not_cond
> -           | expr rel_op^ expr
> +unary_cond : expr rel_op^ expr
> +           | LEFT_PAREN! cond RIGHT_PAREN!
> +           | not_cond           
>             | func_eval
>             | null_check_cond
> +           | bool_cond           
>  ;
>  
> +bool_cond: expr -> ^(BOOL_COND expr);
> +
>  not_cond : NOT^ unary_cond
>  ;
> @@ -784,6 +787,7 @@ eid : rel_str_op
>      | TRUE
>      | FALSE
>      | REALIAS
> +    | BOOL_COND
>  ;
> {code}
> This makes FilterBoolean_23/24 in e2e test fail.
> If this change is intended, we should disable FilterBoolean_23/24.
> If not, we should put the reverted change back to the grammar.
> Thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira