[GitHub] [tinkerpop] spmallette commented on a change in pull request #1302: TINKERPOP-2391 Remove GLV templating system

[GitBox <gi...@apache.org>]

spmallette commented on a change in pull request #1302:
URL: https://github.com/apache/tinkerpop/pull/1302#discussion_r465851158



##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -33,14 +33,43 @@ limitations under the License.
 
     <build>
         <plugins>
-            <!-- Override the execution from gremlin-dotnet to disable code generation from happening a second time -->
             <plugin>
                 <groupId>org.codehaus.gmavenplus</groupId>
                 <artifactId>gmavenplus-plugin</artifactId>
+                <dependencies>
+                    <dependency>
+                        <groupId>org.codehaus.groovy</groupId>
+                        <artifactId>groovy-all</artifactId>
+                        <version>${groovy.version}</version>
+                        <type>pom</type>
+                        <scope>runtime</scope>
+                    </dependency>
+                </dependencies>
                 <executions>
                     <execution>
-                        <id>generate-dsl</id>
-                        <phase/>
+                        <id>update-version</id>

Review comment:
       wow - i keep missing the template reference. thanks for noticing that. i suppose that my changes here get rid of the ability to do SNAPSHOT style releases to nuget. it doesn't appear as though we've ever done one and I'd venture to say that we never will. We would only ever do an "rc" version and we do that by way of a tag in git to capture the commit id from which we release that from (and we don't even bother to commit/push with the pom.xml updated to reflect the "rc"). 
   
   I think that by not worrying about SNAPSHOTs we can do as you say and remove that "template" code in the "deploy" segment of the pom. In place of that "template" code I've added something to stop the build if the version is in SNAPSHOT. That approach does put it at odds with other GLVs which can support a form of SNAPSHOT but for now I don't think that's a problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org