You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/02 08:49:54 UTC

[GitHub] [shardingsphere-elasticjob] TingLL opened a new pull request #1749: Fix typo in Javadoc

TingLL opened a new pull request #1749:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1749


   change root root to root node
   
   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
   -
   -
   -
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1749: Fix typo in Javadoc

Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #1749:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1749


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1749: Fix typo in Javadoc

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1749:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1749#issuecomment-737091153


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=h1) Report
   > Merging [#1749](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=desc) (5642a80) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/30e5f5f1f4209426341dde4339b6b678a2d460b9?el=desc) (30e5f5f) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1749      +/-   ##
   ============================================
   + Coverage     86.03%   86.04%   +0.01%     
     Complexity      108      108              
   ============================================
     Files           255      255              
     Lines          5741     5741              
     Branches        885      885              
   ============================================
   + Hits           4939     4940       +1     
     Misses          483      483              
   + Partials        319      318       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...asticjob/lite/internal/storage/JobNodeStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlU3RvcmFnZS5qYXZh) | `91.07% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `82.53% <0.00%> (+1.58%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=footer). Last update [30e5f5f...5642a80](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1749: Fix typo in Javadoc

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1749:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1749#issuecomment-737091153


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=h1) Report
   > Merging [#1749](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=desc) (5642a80) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/30e5f5f1f4209426341dde4339b6b678a2d460b9?el=desc) (30e5f5f) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1749      +/-   ##
   ============================================
   - Coverage     86.03%   85.90%   -0.13%     
     Complexity      108      108              
   ============================================
     Files           255      255              
     Lines          5741     5741              
     Branches        885      885              
   ============================================
   - Hits           4939     4932       -7     
   - Misses          483      491       +8     
   + Partials        319      318       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...asticjob/lite/internal/storage/JobNodeStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlU3RvcmFnZS5qYXZh) | `87.50% <ø> (-3.58%)` | `0.00 <0.00> (ø)` | |
   | [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-3.18%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=footer). Last update [30e5f5f...5642a80](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org