You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/13 12:54:15 UTC

[GitHub] [maven] cstamas opened a new pull request, #719: [MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x

cstamas opened a new pull request, #719:
URL: https://github.com/apache/maven/pull/719

   Note: current repository change in POM is ONLY to
   make CI run ITs. This PR is placeholder until
   maven-resolver 1.8.0 is released, but until then
   let's see ITs at least.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven] cstamas commented on a diff in pull request #719: [MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x

Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #719:
URL: https://github.com/apache/maven/pull/719#discussion_r850765861


##########
pom.xml:
##########
@@ -45,6 +45,19 @@ under the License.
   <url>https://maven.apache.org/ref/${project.version}/</url>
   <inceptionYear>2001</inceptionYear>
 
+  <repositories>
+    <repository>
+      <id>repository.apache.org</id>
+      <url>https://repository.apache.org/content/repositories/snapshots</url>
+      <releases>
+        <enabled>false</enabled>
+      </releases>
+      <snapshots>
+        <enabled>true</enabled>
+      </snapshots>
+    </repository>
+  </repositories>

Review Comment:
   Now I remember what I mixed up: not snapshot artifacts, but **staged artifacts**....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven] slawekjaranowski commented on a diff in pull request #719: [MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #719:
URL: https://github.com/apache/maven/pull/719#discussion_r849455129


##########
pom.xml:
##########
@@ -45,6 +45,19 @@ under the License.
   <url>https://maven.apache.org/ref/${project.version}/</url>
   <inceptionYear>2001</inceptionYear>
 
+  <repositories>
+    <repository>
+      <id>repository.apache.org</id>
+      <url>https://repository.apache.org/content/repositories/snapshots</url>
+      <releases>
+        <enabled>false</enabled>
+      </releases>
+      <snapshots>
+        <enabled>true</enabled>
+      </snapshots>
+    </repository>
+  </repositories>

Review Comment:
   There is in ASF pom ....
   https://github.com/apache/maven-apache-parent/blob/master/pom.xml#L110-L129
   Is it not the same?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven] cstamas closed pull request #719: [MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x

Posted by GitBox <gi...@apache.org>.
cstamas closed pull request #719: [MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x
URL: https://github.com/apache/maven/pull/719


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven] cstamas commented on a diff in pull request #719: [MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x

Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #719:
URL: https://github.com/apache/maven/pull/719#discussion_r849458128


##########
pom.xml:
##########
@@ -45,6 +45,19 @@ under the License.
   <url>https://maven.apache.org/ref/${project.version}/</url>
   <inceptionYear>2001</inceptionYear>
 
+  <repositories>
+    <repository>
+      <id>repository.apache.org</id>
+      <url>https://repository.apache.org/content/repositories/snapshots</url>
+      <releases>
+        <enabled>false</enabled>
+      </releases>
+      <snapshots>
+        <enabled>true</enabled>
+      </snapshots>
+    </repository>
+  </repositories>

Review Comment:
   eh, missed it :) I assumed maven build does not allow snapshots for some reason (and CI builds w/ snapshots would fail)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org