You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 14:35:13 UTC
[GitHub] [flink] Myasuka commented on a change in pull request #11957: [FLINK-17248] Introduce configuration for pool size of io-executor for ClusterEntrypoint and MiniCluster
Myasuka commented on a change in pull request #11957:
URL: https://github.com/apache/flink/pull/11957#discussion_r425844514
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerSharedServices.java
##########
@@ -157,8 +159,12 @@ public static JobManagerSharedServices fromConfiguration(
throw new IllegalConfigurationException(AkkaUtils.formatDurationParsingErrorMessage());
}
+ final int poolSize = config.getInteger(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE, Hardware.getNumberCPUCores());
+ Preconditions.checkArgument(poolSize > 0,
+ String.format("Illegal pool size (%s) of io-executor for cluster entry-point, please re-configure '%s'.",
+ poolSize, ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE.key()));
final ScheduledExecutorService futureExecutor = Executors.newScheduledThreadPool(
- Hardware.getNumberCPUCores(),
+ poolSize,
new ExecutorThreadFactory("jobmanager-future"));
Review comment:
It's my fault, will fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org