[GitHub] [accumulo] keith-turner commented on a change in pull request #1425: Changes for issue #1419

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1425: Changes for issue #1419
URL: https://github.com/apache/accumulo/pull/1425#discussion_r345808940
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/cryptoImpl/AESCryptoService.java
 ##########
 @@ -133,7 +133,7 @@ public FileDecrypter getFileDecrypter(CryptoEnvironment environment) {
   }
 
   private static boolean checkNoCrypto(byte[] params) {
-    byte[] noCryptoBytes = NO_CRYPTO_VERSION.getBytes(Charset.forName("UTF-8"));
+    byte[] noCryptoBytes = NO_CRYPTO_VERSION.getBytes(StandardCharsets.UTF_8);
 
 Review comment:
   Many places in the codebase that use this constant statically import it.  Like 
   
   https://github.com/apache/accumulo/blob/3c37cc97c12cc3abeb27882fa2f79a64ca32a9f9/core/src/main/java/org/apache/accumulo/core/iteratorsImpl/conf/ColumnSet.java#L19
   
   It would be nice to do that for consistency with other code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services