You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/12 16:15:55 UTC
[GitHub] [dubbo] XenoAmess opened a new issue #9771: 3.0.5 to 3.0.6 api change cause compile failure, thus CAN cause dependency hell.
XenoAmess opened a new issue #9771:
URL: https://github.com/apache/dubbo/issues/9771
<!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: migrating from 3.0.5 to 3.0.6
### Steps to reproduce this issue
https://github.com/XenoAmess/metasploit-java-external-module/runs/5522599197?check_suite_focus=true
https://github.com/XenoAmess/metasploit-java-external-module/pull/65
### Expected Behavior
DO NOT DELETE EXISTED API WITHIN SAME MAJOR VERSION
PLEASE JUST FOLLOW SEMVER
### Actual Behavior
compile failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess edited a comment on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067724734
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose. I will add it back later.
>
> For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
you can move it to some package named 'inner' or something, and add annotations to aware anybody outside this repo do not use it, like what hotspot kids do in jdk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess commented on issue #9771: 3.0.5 to 3.0.6 api change cause compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1065911239
Stronglly suggest you add a BC aware maven plugin like other normal apache project.
An aimed to be widely used library should have sense of responsibility for not causing dependencyn hell.
If you have techniquelly trouble I can offer help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess edited a comment on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067724734
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose. I will add it back later.
>
> For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
You can move it to some package named 'inner' or something, and add annotations to aware anybody outside this repo do not use it, like what hotspot kids do in jdk.
But usually we only cause BC when we increase major version.
I suggest:
1. Adding a backward function for now
2. list **move it to 'inner' package** to next dubbo major version milestone.
3. add a BC aware mechanism, and invoke it at least once per before release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess commented on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1065911633
https://garygregory.wordpress.com/2020/06/14/how-we-handle-binary-compatibility-at-apache-commons/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess edited a comment on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067724734
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose. I will add it back later.
>
> For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
You can move it to some package named 'inner' or something, and add annotations to aware anybody outside this repo do not use it, like what hotspot kids do in jdk.
But usually we only cause BC when we increase major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj closed issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
chickenlj closed issue #9771:
URL: https://github.com/apache/dubbo/issues/9771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess edited a comment on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1065911633
Additional material for beginers if you even don't know what BC I mean.
https://garygregory.wordpress.com/2020/06/14/how-we-handle-binary-compatibility-at-apache-commons/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess edited a comment on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067724734
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose. I will add it back later.
>
> For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
You can move it to some package named 'inner' or something, and add annotations to aware anybody outside this repo do not use it, like what hotspot kids do in jdk.
But usually we only cause BC when we increase major version.
I suggest:
1. Adding a backward function for now
2. list **move it to 'inner' package** to next dubbo major version milestone.
3. add a BC aware mechanism before next release, and invoke it at least once per before release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067654873
`AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose.
I will add it back later.
For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess commented on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067724734
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)`为兼容 jdk17 的目的而更改。 我稍后会添加回来。
>
> 对于此类 API 重大更改案例，我认为我们可以尝试将这些 API 移出到向用户公开的单个模块中。
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose. I will add it back later.
>
> For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
you can move it to some package named 'inner' or something, and add annotations to aware anybody outside this repo do not use it, like what hotspot kids do in jdk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess edited a comment on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067724734
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose. I will add it back later.
>
> For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
@AlbumenJ
You can move it to some package named 'inner' or something, and add annotations to aware anybody outside this repo do not use it, like what hotspot kids do in jdk.
But usually we only cause BC when we increase major version.
I suggest:
1. Adding a backward function for now
2. list **move it to 'inner' package** to next dubbo major version milestone.
3. add a BC aware mechanism before next release, and invoke it at least once per before release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] XenoAmess edited a comment on issue #9771: 3.0.5 to 3.0.6 api change cause project using it suffer compile failure, thus CAN cause dependency hell.
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on issue #9771:
URL: https://github.com/apache/dubbo/issues/9771#issuecomment-1067724734
> `AbstractCompiler.doCompile(Class<?>,ClassLoader,String,String)` is changed for jdk17 compatible purpose. I will add it back later.
>
> For such API breaking changes cases, I think we can try to move out those API to a single module which expose to users.
You can move it to some package named 'inner' or something, and add annotations to aware anybody outside this repo do not use it, like what hotspot kids do in jdk.
But usually we only cause BC when we increase major version.
I suggest:
1. Adding a backward function for now
2. list **move it to 'inner' package** to next dubbo major version milestone.
3. add a BC aware mechanism now, and invoke it at least once per before release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org