You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/04/28 12:34:00 UTC
[jira] [Commented] (OFBIZ-12940) Modal title not supported on hyperlink in form fields
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947813#comment-17947813 ]
ASF subversion and git services commented on OFBIZ-12940:
---------------------------------------------------------
Commit 7583482a160635d5560368958e17f1064d08ca36 in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7583482a16 ]
Fixed: Synchronize renderTextField and makeHyperlingString macro (OFBIZ-13183) (OFBIZ-12940)
After improvement 'Form inputs: use "required" attribute on mandatory fields, validation breaks if "required-field-style" is not empty' (OFBIZ-13183) and 'Support "text" attribute on hyperlinks in forms' (OFBIZ-12940), renderTextField and makeHyperlingString macro are non synchronised between html library and other type (cvs, text, xls, xml and fo).
We propagate macro modifications to other types.
> Modal title not supported on hyperlink in form fields
> -----------------------------------------------------
>
> Key: OFBIZ-12940
> URL: https://issues.apache.org/jira/browse/OFBIZ-12940
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: 18.12.12, 18.12.13, 22.01.01
> Reporter: Florian Motteau
> Assignee: Gil Portenseigne
> Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: image-2024-03-14-08-58-13-835.png
>
>
> Hyperlinks elements can trigger the opening of a modal window (link-type="layered-modal"). OFBiz uses jQuery UI Dialog to achieve this, and parameters for this library are passed through a set of data-dialog-* ** attributes on the "a" tag, in "HtmlFormMacroLibrary::makeHyperlinkString" Freemarker macro. Then in OfbizUtil.js, links that should open modals are processed : data-dialog-* are used to configure jQueryUI Dialog module.
>
> In OfbizUtil.js, data-dialog-text attribute is used to set the title of the modal (text in the colored top bar). The value of this attribute is set using the "text" parameter in "makeHyperlinkString" macro. However, this macro does not declare a "text" parameter in its signature, and HtmlMacroFormRenderer::makeHyperlinkString does not support it.
> As a result, we cannot set the modal title when using a `hyperlink` tag with a `text` attribute in a form (although the code indicates otherwise).
> !image-2024-03-14-08-58-13-835.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)