You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Markus Jung <ju...@apache.org> on 2024/07/01 06:55:35 UTC
Re: CXF 4.1.0 Fork Release - Thoughts?
Hey Richard,
IMO there's 3 possible solutions to handle this. I've ordered these in
what I believe is the amount of effort required to set up:
1. Copy CXF sources into TomEE sources so we can simply release it with
the next milestone
2. Release current CXF snapshot outside of the ASF and use it as a
dependency
3. Formally create a tomee subproject, put CXF sources there, release
and use it
Simply copying CXF sources into the tomee project (and deleting them
later on once we got official 4.1 artifacts) is super quick and simple,
but I'm really not sure if this is something we should be doing.
Releasing CXF somewhere else can be pretty easy but it requires some
more work to set things up and deploy the release to some Maven
repository. (GitHub artifacts? Maven Central?)
Setting up a tomee subproject is probably pretty much the same effort
but it means we need to adhere to the ASF release process, do a formal
vote etc. Also not sure how easily such a subproject can be abandoned
again once CXF 4.1 arrives and we don't need this setup anymore.
IMHO both solutions 1 and 2 are quick and desirable, though 1 would
really need to be discussed. 3 requires at least a couple of people to
be involved to do a formal vote.
Any other thoughts on this?
Thanks
Markus
On 27.06.24 15:34, Richard Zowalla wrote:
> Hi all,
>
> I just forked CXF (from the latest green build with 7ab74899002f69055175dacae946b7664413c9ad) on my personal repo and did a search / replace party for the group id from org.apache.cxf to org.apache.tomee.cxf [1]
> Of course it would need to be moved in a tomee-related repo. The build works fine locally.
>
> How shall we proceed with it?
>
> Do we need to run a formal vote to release a milestone maven artifact under our own group id (with all the necessities such as providing the source code via svn) or is it sufficient to do this for maven only (and vote regardless).
> Other possibility would be to release outside of the ASF umbrella and add that as dependency.
>
> Thoughts?
>
> Gruß
> Richard
>
> [1] https://github.com/rzo1/cxf/tree/cxf-4.1.0-tomee
Re: CXF 4.1.0 Fork Release - Thoughts?
Posted by Markus Jung <ju...@apache.org>.
Another quick thought I had: This will break builds for users of the
tomee BOMs that rely on CXF. This would've also been the case with any
of the approaches to solve this. But IMHO this isn't as big of a problem
right now, we're still in the stage of pretty early milestones of a new
major release anyways and stuff breaking is somewhat to be expected ;)
Awesome work!
On 01.07.24 15:59, Richard Zowalla wrote:
> Hi all,
>
> managed to deploy my fork to central. Here is the PR: https://github.com/apache/tomee/pull/1229
>
> (REST) TCK is still fine.
>
> Gruß
> Richard
>
> On 2024/07/01 08:49:41 Richard Zowalla wrote:
>> Copying the whole bunch of code into TomEE doesn’t look like a good idea (imho).
>>
>> I just tested putting packages up on GitHub registry but this has the limitation, that people (and CI) need additional authentication (but it is a proof, that it would work basically)
>> Don’t know what is currently needed to put something directly on Maven Central (would need to do some research) but I think, that it might be quite a lot of work for a one time thing or does someone have experience in that area (the process changed a few weeks ago) ?
>>
>>
>>> Am 01.07.2024 um 08:55 schrieb Markus Jung <ju...@apache.org>:
>>>
>>> Hey Richard,
>>>
>>>
>>> IMO there's 3 possible solutions to handle this. I've ordered these in what I believe is the amount of effort required to set up:
>>>
>>> 1. Copy CXF sources into TomEE sources so we can simply release it with the next milestone
>>> 2. Release current CXF snapshot outside of the ASF and use it as a dependency
>>> 3. Formally create a tomee subproject, put CXF sources there, release and use it
>>>
>>>
>>> Simply copying CXF sources into the tomee project (and deleting them later on once we got official 4.1 artifacts) is super quick and simple, but I'm really not sure if this is something we should be doing.
>>>
>>> Releasing CXF somewhere else can be pretty easy but it requires some more work to set things up and deploy the release to some Maven repository. (GitHub artifacts? Maven Central?)
>>>
>>> Setting up a tomee subproject is probably pretty much the same effort but it means we need to adhere to the ASF release process, do a formal vote etc. Also not sure how easily such a subproject can be abandoned again once CXF 4.1 arrives and we don't need this setup anymore.
>>>
>>>
>>> IMHO both solutions 1 and 2 are quick and desirable, though 1 would really need to be discussed. 3 requires at least a couple of people to be involved to do a formal vote.
>>>
>>> Any other thoughts on this?
>>>
>>>
>>>
>>> Thanks
>>>
>>> Markus
>>>
>>> On 27.06.24 15:34, Richard Zowalla wrote:
>>>> Hi all,
>>>>
>>>> I just forked CXF (from the latest green build with 7ab74899002f69055175dacae946b7664413c9ad) on my personal repo and did a search / replace party for the group id from org.apache.cxf to org.apache.tomee.cxf [1]
>>>> Of course it would need to be moved in a tomee-related repo. The build works fine locally.
>>>>
>>>> How shall we proceed with it?
>>>>
>>>> Do we need to run a formal vote to release a milestone maven artifact under our own group id (with all the necessities such as providing the source code via svn) or is it sufficient to do this for maven only (and vote regardless).
>>>> Other possibility would be to release outside of the ASF umbrella and add that as dependency.
>>>>
>>>> Thoughts?
>>>>
>>>> Gruß
>>>> Richard
>>>>
>>>> [1] https://github.com/rzo1/cxf/tree/cxf-4.1.0-tomee
>>
Re: CXF 4.1.0 Fork Release - Thoughts?
Posted by Richard Zowalla <rz...@apache.org>.
Hi all,
managed to deploy my fork to central. Here is the PR: https://github.com/apache/tomee/pull/1229
(REST) TCK is still fine.
Gruß
Richard
On 2024/07/01 08:49:41 Richard Zowalla wrote:
> Copying the whole bunch of code into TomEE doesn’t look like a good idea (imho).
>
> I just tested putting packages up on GitHub registry but this has the limitation, that people (and CI) need additional authentication (but it is a proof, that it would work basically)
> Don’t know what is currently needed to put something directly on Maven Central (would need to do some research) but I think, that it might be quite a lot of work for a one time thing or does someone have experience in that area (the process changed a few weeks ago) ?
>
>
> > Am 01.07.2024 um 08:55 schrieb Markus Jung <ju...@apache.org>:
> >
> > Hey Richard,
> >
> >
> > IMO there's 3 possible solutions to handle this. I've ordered these in what I believe is the amount of effort required to set up:
> >
> > 1. Copy CXF sources into TomEE sources so we can simply release it with the next milestone
> > 2. Release current CXF snapshot outside of the ASF and use it as a dependency
> > 3. Formally create a tomee subproject, put CXF sources there, release and use it
> >
> >
> > Simply copying CXF sources into the tomee project (and deleting them later on once we got official 4.1 artifacts) is super quick and simple, but I'm really not sure if this is something we should be doing.
> >
> > Releasing CXF somewhere else can be pretty easy but it requires some more work to set things up and deploy the release to some Maven repository. (GitHub artifacts? Maven Central?)
> >
> > Setting up a tomee subproject is probably pretty much the same effort but it means we need to adhere to the ASF release process, do a formal vote etc. Also not sure how easily such a subproject can be abandoned again once CXF 4.1 arrives and we don't need this setup anymore.
> >
> >
> > IMHO both solutions 1 and 2 are quick and desirable, though 1 would really need to be discussed. 3 requires at least a couple of people to be involved to do a formal vote.
> >
> > Any other thoughts on this?
> >
> >
> >
> > Thanks
> >
> > Markus
> >
> > On 27.06.24 15:34, Richard Zowalla wrote:
> >> Hi all,
> >>
> >> I just forked CXF (from the latest green build with 7ab74899002f69055175dacae946b7664413c9ad) on my personal repo and did a search / replace party for the group id from org.apache.cxf to org.apache.tomee.cxf [1]
> >> Of course it would need to be moved in a tomee-related repo. The build works fine locally.
> >>
> >> How shall we proceed with it?
> >>
> >> Do we need to run a formal vote to release a milestone maven artifact under our own group id (with all the necessities such as providing the source code via svn) or is it sufficient to do this for maven only (and vote regardless).
> >> Other possibility would be to release outside of the ASF umbrella and add that as dependency.
> >>
> >> Thoughts?
> >>
> >> Gruß
> >> Richard
> >>
> >> [1] https://github.com/rzo1/cxf/tree/cxf-4.1.0-tomee
>
>
Re: CXF 4.1.0 Fork Release - Thoughts?
Posted by Richard Zowalla <rz...@apache.org>.
Copying the whole bunch of code into TomEE doesn’t look like a good idea (imho).
I just tested putting packages up on GitHub registry but this has the limitation, that people (and CI) need additional authentication (but it is a proof, that it would work basically)
Don’t know what is currently needed to put something directly on Maven Central (would need to do some research) but I think, that it might be quite a lot of work for a one time thing or does someone have experience in that area (the process changed a few weeks ago) ?
> Am 01.07.2024 um 08:55 schrieb Markus Jung <ju...@apache.org>:
>
> Hey Richard,
>
>
> IMO there's 3 possible solutions to handle this. I've ordered these in what I believe is the amount of effort required to set up:
>
> 1. Copy CXF sources into TomEE sources so we can simply release it with the next milestone
> 2. Release current CXF snapshot outside of the ASF and use it as a dependency
> 3. Formally create a tomee subproject, put CXF sources there, release and use it
>
>
> Simply copying CXF sources into the tomee project (and deleting them later on once we got official 4.1 artifacts) is super quick and simple, but I'm really not sure if this is something we should be doing.
>
> Releasing CXF somewhere else can be pretty easy but it requires some more work to set things up and deploy the release to some Maven repository. (GitHub artifacts? Maven Central?)
>
> Setting up a tomee subproject is probably pretty much the same effort but it means we need to adhere to the ASF release process, do a formal vote etc. Also not sure how easily such a subproject can be abandoned again once CXF 4.1 arrives and we don't need this setup anymore.
>
>
> IMHO both solutions 1 and 2 are quick and desirable, though 1 would really need to be discussed. 3 requires at least a couple of people to be involved to do a formal vote.
>
> Any other thoughts on this?
>
>
>
> Thanks
>
> Markus
>
> On 27.06.24 15:34, Richard Zowalla wrote:
>> Hi all,
>>
>> I just forked CXF (from the latest green build with 7ab74899002f69055175dacae946b7664413c9ad) on my personal repo and did a search / replace party for the group id from org.apache.cxf to org.apache.tomee.cxf [1]
>> Of course it would need to be moved in a tomee-related repo. The build works fine locally.
>>
>> How shall we proceed with it?
>>
>> Do we need to run a formal vote to release a milestone maven artifact under our own group id (with all the necessities such as providing the source code via svn) or is it sufficient to do this for maven only (and vote regardless).
>> Other possibility would be to release outside of the ASF umbrella and add that as dependency.
>>
>> Thoughts?
>>
>> Gruß
>> Richard
>>
>> [1] https://github.com/rzo1/cxf/tree/cxf-4.1.0-tomee