You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/01/19 10:43:53 UTC

Review Request 42491: WIP: Updated allocatable() to distinguish different resources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42491/
-----------------------------------------------------------

Review request for mesos and Klaus Ma.


Bugs: MESOS-4426
    https://issues.apache.org/jira/browse/MESOS-4426


Repository: mesos


Description
-------

Updated allocatable() to distinguish different resources.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a 
  src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863 

Diff: https://reviews.apache.org/r/42491/diff/


Testing
-------


Thanks,

Guangya Liu


Re: Review Request 42491: Updated allocatable() to distinguish different resources.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42491/
-----------------------------------------------------------

(Updated 三月 11, 2016, 9:12 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4426
    https://issues.apache.org/jira/browse/MESOS-4426


Repository: mesos


Description
-------

Updated allocatable() to distinguish different resources.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32 
  src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42491/diff/


Testing
-------

make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu


Re: Review Request 42491: Updated allocatable() to distinguish different resources.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42491/
-----------------------------------------------------------

(Updated 一月 23, 2016, 6:18 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4426
    https://issues.apache.org/jira/browse/MESOS-4426


Repository: mesos


Description
-------

Updated allocatable() to distinguish different resources.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 65c7e6b15c5308c0910667e1b12f39b21293a316 
  src/tests/hierarchical_allocator_tests.cpp b1cb955b7eb1213c7ba4a9c5181545bb49154f06 

Diff: https://reviews.apache.org/r/42491/diff/


Testing
-------

make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu


Re: Review Request 42491: Updated allocatable() to distinguish different resources.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42491/
-----------------------------------------------------------

(Updated 一月 20, 2016, 1:41 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Summary (updated)
-----------------

Updated allocatable() to distinguish different resources.


Bugs: MESOS-4426
    https://issues.apache.org/jira/browse/MESOS-4426


Repository: mesos


Description
-------

Updated allocatable() to distinguish different resources.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp e32ee4aa3ed9793bb5a99233e699e5cc2bdd796b 
  src/tests/hierarchical_allocator_tests.cpp 953712149bd951789beb29c72779c4ac65aa48dc 

Diff: https://reviews.apache.org/r/42491/diff/


Testing
-------

make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu


Re: Review Request 42491: WIP: Updated allocatable() to distinguish different resources.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42491/
-----------------------------------------------------------

(Updated 一月 20, 2016, 1:41 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4426
    https://issues.apache.org/jira/browse/MESOS-4426


Repository: mesos


Description
-------

Updated allocatable() to distinguish different resources.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp e32ee4aa3ed9793bb5a99233e699e5cc2bdd796b 
  src/tests/hierarchical_allocator_tests.cpp 953712149bd951789beb29c72779c4ac65aa48dc 

Diff: https://reviews.apache.org/r/42491/diff/


Testing (updated)
-------

make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu


Re: Review Request 42491: WIP: Updated allocatable() to distinguish different resources.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42491/#review115266
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 42386, 40632, 41847, 41791, 42113, 42194, 41848, 42491]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 19, 2016, 9:43 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42491/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 9:43 a.m.)
> 
> 
> Review request for mesos and Klaus Ma.
> 
> 
> Bugs: MESOS-4426
>     https://issues.apache.org/jira/browse/MESOS-4426
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated allocatable() to distinguish different resources.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a 
>   src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863 
> 
> Diff: https://reviews.apache.org/r/42491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>