You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by nicefan <gi...@git.apache.org> on 2017/03/21 17:02:32 UTC

[GitHub] incubator-weex pull request #141: Class common's problem

GitHub user nicefan opened a pull request:

    https://github.com/apache/incubator-weex/pull/141

    Class  common's problem 

    I use `<style src="assets/common.styl" lang="stylus"/>`  require class, want class shared\uff0cbut no good, becasue I view the build dist file, these class all repeat, is not one module pack in.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-weex 0.11-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #141
    
----
commit 21878b0f7a64b0e8075c65ca925b5a2811e57b40
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-05T13:22:15Z

    * [ios] support delete header in the middle of list dynamicly

commit 57d5ab81239a5079042dd716bf8b9ef89dcf12da
Author: sospartan zheng <so...@apache.org>
Date:   2017-03-05T15:21:14Z

    Update package.json

commit 11352c71b600a1f04a9063a1db8bf7da6361d129
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T02:28:51Z

    Revert "* [ios] support delete header in the middle of list dynamicly"
    
    This reverts commit 21878b0f7a64b0e8075c65ca925b5a2811e57b40.

commit 3621001f16cbdfdc0ce6b7848fc771401def5550
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T02:32:38Z

    * [ios] revert recycler merge

commit 917013e25a5c6a6090897e3acd57e07b7c7a5caa
Author: \u9690\u98ce <cx...@gmail.com>
Date:   2017-03-06T02:45:38Z

    Merge remote-tracking branch 'upstream/0.11-dev' into 0.11-dev

commit 33ba60a47b1afaedb8ba70d6b7c5ffc7796aed32
Author: sospartan <so...@gmail.com>
Date:   2017-03-06T02:53:45Z

    Merge branch 'android-bugfix-NPE' of http://github.com/zshshr/incubator-weex into 0.11-dev
    This closes #31

commit 0666504b790476ba64270c324676132570f3ca29
Author: sospartan <so...@gmail.com>
Date:   2017-03-06T02:55:13Z

    Merge branch '0.11-dev' of https://git-wip-us.apache.org/repos/asf/incubator-weex; branch '0.11-dev-fixinputnpe' of github.com:sospartan/incubator-weex into 0.11-dev
    This closes #24

commit c6fddbea8b5bba05809922cb1a7d766fafdcc0e9
Author: \u9690\u98ce <cx...@gmail.com>
Date:   2017-03-06T02:59:54Z

    * [dev] Add Feature Recycler and Waterfall

commit 287114ddc579651215839f37dead585f81a5c951
Author: \u9690\u98ce <cx...@gmail.com>
Date:   2017-03-06T03:00:20Z

    Revert "Revert "* [ios] support delete header in the middle of list dynamicly""
    
    This reverts commit 11352c71b600a1f04a9063a1db8bf7da6361d129.

commit b181c8943ab5367df135408abf4e0142a91ea5a8
Author: sospartan <so...@gmail.com>
Date:   2017-03-06T03:04:18Z

    Merge branch '0.11-dev' into 0.11-dev-fix-pos-fixed

commit a9f38b82378f4d21ceb5571bd44ea3997e0b75ff
Author: \u9690\u98ce <yi...@alibaba-inc.com>
Date:   2017-03-06T03:32:21Z

    * [ios] fix compile error.

commit 166442ebf0f5e810bd88e5a93d4310f7f58cf6f8
Author: xiayun <xi...@163.com>
Date:   2017-03-06T03:46:33Z

    modify unit test

commit 4f7f5a670f57cd128f8a459b2036876a09cca803
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T03:51:14Z

    Merge branch '0.11-dev' of https://github.com/xiayun200825/incubator-weex into 0.11-dev

commit 7706e8a66a823a3f466f4628fc7de06f75bbf8e7
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T03:51:33Z

    Merge branch '0.11-dev' of https://git-wip-us.apache.org/repos/asf/incubator-weex into 0.11-dev

commit 610c3f1b5e8614af920842f52f234c0cc3a83a42
Author: \u9690\u98ce <yi...@alibaba-inc.com>
Date:   2017-03-06T04:11:20Z

    Merge remote-tracking branch 'upstream/0.11-dev' into 0.11-dev

commit 5fb9f684c3f15fecfb5cbc439d15ccd3f19ef8a2
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T07:19:43Z

    Merge branch '0.11-dev' of https://github.com/bluebird78999/incubator-weex into 0.11-dev

commit 1c3b80392207b63263265ee07a6d9456afe7ccdc
Author: \u7167\u70c8 <ju...@alibaba-inc.com>
Date:   2017-03-06T07:30:44Z

    + [android] add interface to support module and component validate

commit 95883e9fa6c817ca808ce55dcd6fc9c686cb3b3e
Author: sospartan zheng <so...@apache.org>
Date:   2017-03-06T07:33:50Z

    * [test] trigger travis test

commit 7af22d393f0b96ea55d2a3b0f3b9d14803dc6087
Author: sospartan <so...@gmail.com>
Date:   2017-03-06T08:47:34Z

    * [android] use a dom for destroy , avoid NPE after component destroyed.

commit 5eaf66a781f0229e654017eeeb8882a854f05f17
Author: sospartan <so...@gmail.com>
Date:   2017-03-06T09:14:06Z

    Merge branch 'android-feature-updateStyle&updateAttrs' of http://github.com/zshshr/incubator-weex into 0.11-dev
    This closes #30

commit 2c05aa6c7a4509e170911d86be7288c99df920a9
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T09:35:03Z

    Merge branch 'ios-bugfix-textarea-0.11-dev' of https://github.com/kfeagle/incubator-weex into 0.11-dev

commit 0935fcd26fd4a9958445cbdde36648b130fccf30
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T09:35:59Z

    Merge branch '0.11-dev' of https://git-wip-us.apache.org/repos/asf/incubator-weex into 0.11-dev

commit 19abc48c958ec464eb3714e036a4991d79957d74
Author: zshshr <zh...@gmail.com>
Date:   2017-03-06T09:47:36Z

    * [android] avoid NPE case and remove space

commit 56c0f951e624a94b7a2f5c14c1f3a29015918ff2
Author: JZTech-Wangll <lo...@louis-macbook-pro.local>
Date:   2017-03-06T09:50:56Z

    fix WXWebView weak reference with delegate when WXWebView dealloc, fix hit reply too quickly cause view render crash

commit 7844d55dd6ebf4aa45dcf3e8fe4e4a0c878f9d59
Author: \u516e\u74dc <xi...@alibaba-inc.com>
Date:   2017-03-06T10:06:47Z

    + [ios] add interface to support validation for modules and components

commit 4418c330c1181bb6d0a8de9f9ee8b07e2a335646
Author: sospartan <so...@gmail.com>
Date:   2017-03-06T10:10:34Z

    * [android] fix ConcurrentModificationException in list sticky map

commit c0b9b1d2e29d8442dc06dd54031beedd91ad6ceb
Author: zshshr <zh...@gmail.com>
Date:   2017-03-06T10:14:07Z

    * [android] remove space line

commit 77c1a58aba2263585f2f78776b6355c761dce3ee
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T11:09:51Z

    Merge branch '0.11-dev' of https://github.com/cxfeng1/incubator-weex into 0.11-dev

commit 08bc49edf035237e6865c0d4b18a78c54902ab46
Author: xiayun <xi...@163.com>
Date:   2017-03-06T11:13:05Z

    modify unit test

commit 529f51720e4d82c9a19ad0fb9cf7c85e8c633af5
Author: cxfeng <cx...@gmail.com>
Date:   2017-03-06T11:22:56Z

    Merge branch '0.11-dev' of https://github.com/boboning/incubator-weex into 0.11-dev

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #141: Class common's problem

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/141
  
    
    <!--
      1 failure:  Code file ios/sdk...
      14 warning:  These new JS file..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C...
      
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>Code file ios/sdk/WeexSDKTests/WXStorageTests.m does not have the copyright header.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>These new JS files do not have Flow enabled: test/scripts/components/image-onload.test.js, test/scripts/components/scroller-fixed.test.js</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/WXStyle.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/flex/CSSNode.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/animation/WXAnimationModule.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/helper/WXStickyHelper.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/border/BorderDrawable.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/listview/WXRecyclerView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/refresh/wrapper/BaseBounceView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/refresh/wrapper/BounceRecyclerView.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #141: Class common's problem

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #141: Class common's problem

Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:

    https://github.com/apache/incubator-weex/pull/141
  
    We will merge 0.11-dev to master when v0.11 released. So this PR will not proceed currently. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---