You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/14 04:18:05 UTC
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2722: [Engine] [ClassLoader] Add log class to default parent first class
Hisoka-X commented on code in PR #2722:
URL: https://github.com/apache/incubator-seatunnel/pull/2722#discussion_r970290618
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/loader/SeatunnelChildFirstClassLoader.java:
##########
@@ -27,17 +27,26 @@
public class SeatunnelChildFirstClassLoader extends SeatunnelBaseClassLoader {
private final String[] alwaysParentFirstPatterns;
- private static final String SEATUNNEL_CLASS_PATTERN = "org.apache.seatunnel.";
+ private static final String[] DEFAULT_PARENT_FIRST_PATTERNS = new String[]{
Review Comment:
We can do this after merge into dev, cause ours option in https://github.com/apache/incubator-seatunnel/pull/2179/files#diff-be39eb1f82bdd74a53153699ceab3303d447421d555dcaf6dc60d53bbc60a180
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/loader/SeatunnelChildFirstClassLoader.java:
##########
@@ -27,17 +27,26 @@
public class SeatunnelChildFirstClassLoader extends SeatunnelBaseClassLoader {
private final String[] alwaysParentFirstPatterns;
- private static final String SEATUNNEL_CLASS_PATTERN = "org.apache.seatunnel.";
+ private static final String[] DEFAULT_PARENT_FIRST_PATTERNS = new String[]{
Review Comment:
We can do this after merge into dev, because ours option in https://github.com/apache/incubator-seatunnel/pull/2179/files#diff-be39eb1f82bdd74a53153699ceab3303d447421d555dcaf6dc60d53bbc60a180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org