You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Sean Kelly <ho...@seank.com> on 2016/02/05 00:54:42 UTC
[Discuss] Process question
I see from the mail below that pull request was closed and I see that
master now has my PR code. However, the JIRA issue is still open where I
would have expected it to be marked resolved. Is there more that I need to
do or?
Sean
---------- Forwarded message ----------
From: asfgit <gi...@git.apache.org>
Date: Thu, Feb 4, 2016 at 3:18 AM
Subject: [GitHub] cordova-plugin-inappbrowser pull request: CB-7786
android: add new...
To: dev@cordova.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [Discuss] Process question
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
Yeap, I completely forgot to update associated JIRA issue, fixed. Sean, thank you for the patch!
PS. This is covered in the PR processing documentation[1]:
Step 7: Update JIRA
[1] https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md
-Sergey
-----Original Message-----
From: Shazron [mailto:shazron@gmail.com]
Sent: Friday, February 5, 2016 3:14 AM
To: dev@cordova.apache.org
Subject: Re: [Discuss] Process question
The committer, in this case sgrebnov, would close the issue, or if you are the reporter of the issue, if the fix is satisfactory, you can close it.
On Thu, Feb 4, 2016 at 4:07 PM, Joe Bowser <bo...@gmail.com> wrote:
> Ideally either the person who pulled in the request, or you would
> confirm that it landed in master and that it works as you intended.
> You can test it and indicate that it's closed if you want to move
> things forward a bit faster.
>
> On Thu, Feb 4, 2016 at 3:54 PM, Sean Kelly <ho...@seank.com> wrote:
>
>> I see from the mail below that pull request was closed and I see that
>> master now has my PR code. However, the JIRA issue is still open
>> where I would have expected it to be marked resolved. Is there more
>> that I need to do or?
>>
>> Sean
>>
>>
>> ---------- Forwarded message ----------
>> From: asfgit <gi...@git.apache.org>
>> Date: Thu, Feb 4, 2016 at 3:18 AM
>> Subject: [GitHub] cordova-plugin-inappbrowser pull request: CB-7786
>> android: add new...
>> To: dev@cordova.apache.org
>>
>>
>> Github user asfgit closed the pull request at:
>>
>> https://github.com/apache/cordova-plugin-inappbrowser/pull/132
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and
>> have your reply appear on GitHub as well. If your project does not
>> have this feature enabled and wishes so, or if the feature is enabled
>> but not working, please contact infrastructure at
>> infrastructure@apache.org or file a JIRA ticket with INFRA.
>> ---
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [Discuss] Process question
Posted by Shazron <sh...@gmail.com>.
The committer, in this case sgrebnov, would close the issue, or if you
are the reporter of the issue, if the fix is satisfactory, you can
close it.
On Thu, Feb 4, 2016 at 4:07 PM, Joe Bowser <bo...@gmail.com> wrote:
> Ideally either the person who pulled in the request, or you would confirm
> that it landed in master and that it works as you intended. You can test
> it and indicate that it's closed if you want to move things forward a bit
> faster.
>
> On Thu, Feb 4, 2016 at 3:54 PM, Sean Kelly <ho...@seank.com> wrote:
>
>> I see from the mail below that pull request was closed and I see that
>> master now has my PR code. However, the JIRA issue is still open where I
>> would have expected it to be marked resolved. Is there more that I need to
>> do or?
>>
>> Sean
>>
>>
>> ---------- Forwarded message ----------
>> From: asfgit <gi...@git.apache.org>
>> Date: Thu, Feb 4, 2016 at 3:18 AM
>> Subject: [GitHub] cordova-plugin-inappbrowser pull request: CB-7786
>> android: add new...
>> To: dev@cordova.apache.org
>>
>>
>> Github user asfgit closed the pull request at:
>>
>> https://github.com/apache/cordova-plugin-inappbrowser/pull/132
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working, please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [Discuss] Process question
Posted by Joe Bowser <bo...@gmail.com>.
Ideally either the person who pulled in the request, or you would confirm
that it landed in master and that it works as you intended. You can test
it and indicate that it's closed if you want to move things forward a bit
faster.
On Thu, Feb 4, 2016 at 3:54 PM, Sean Kelly <ho...@seank.com> wrote:
> I see from the mail below that pull request was closed and I see that
> master now has my PR code. However, the JIRA issue is still open where I
> would have expected it to be marked resolved. Is there more that I need to
> do or?
>
> Sean
>
>
> ---------- Forwarded message ----------
> From: asfgit <gi...@git.apache.org>
> Date: Thu, Feb 4, 2016 at 3:18 AM
> Subject: [GitHub] cordova-plugin-inappbrowser pull request: CB-7786
> android: add new...
> To: dev@cordova.apache.org
>
>
> Github user asfgit closed the pull request at:
>
> https://github.com/apache/cordova-plugin-inappbrowser/pull/132
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>