You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/25 19:38:10 UTC

[GitHub] [spark] kiszk edited a comment on issue #23098: [SPARK-26132][BUILD][CORE] Remove support for Scala 2.11 in Spark 3.0.0

kiszk edited a comment on issue #23098: [SPARK-26132][BUILD][CORE] Remove support for Scala 2.11 in Spark 3.0.0
URL: https://github.com/apache/spark/pull/23098#issuecomment-524657357
 
 
   @sowen I realized that this PR causes an error when we execute `do-release-docker.sh` for branch-2.3.
   ```
   ...
   Checked out revision 35358.
   Copying release tarballs
   cp: cannot stat 'pyspark-*': No such file or directory
   ```
   
   For Spark 2.4, `PUBLISH_SCALA_2_11 = 1, PUBLISH_SCALA_2_10=1`   
   For Spark 2.3, `PUBLISH_SCALA_2_11 = 1, PUBLISH_SCALA_2_10=0`
   Since [This change](https://github.com/apache/spark/commit/8bc304f97ee693b57f33fa6708eb63e2d641c609#diff-01ca42240614718522afde4d4885b40dR293) does not pass `"withpip,withr"`, the script does not build `pyspark-*` and `SparkR_*`.
   
   Should we use the original code in 
   ```
     if [[ $PUBLISH_SCALA_2_11 = 1 ]]; then
       ...
     fi
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org