You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/27 03:34:26 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #37682: [SPARK-40239][CORE] Remove duplicated 'fraction' validation in RDD.sample
zhengruifeng opened a new pull request, #37682:
URL: https://github.com/apache/spark/pull/37682
### What changes were proposed in this pull request?
remove duplicated validation
### Why are the changes needed?
there was already a validation
```
require(fraction >= 0,
s"Fraction must be nonnegative, but got ${fraction}")
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing testsuites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37682: [SPARK-40239][CORE] Remove duplicated 'fraction' validation in RDD.sample
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37682:
URL: https://github.com/apache/spark/pull/37682#issuecomment-1229378447
merged to master, thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #37682: [SPARK-40239][CORE] Remove duplicated 'fraction' validation in RDD.sample
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #37682: [SPARK-40239][CORE] Remove duplicated 'fraction' validation in RDD.sample
URL: https://github.com/apache/spark/pull/37682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org