[GitHub] ZiyueHuang opened a new pull request #8721: fix custom op for backward compatibility

[GitBox <gi...@apache.org>]

ZiyueHuang opened a new pull request #8721: fix custom op for backward compatibility
URL: https://github.com/apache/incubator-mxnet/pull/8721
 
 
   ## Description ##
   Before this PR, the LR in sparse example is broken due to to the custom op, and the added test will throw err message,
   ```
   Error in mult.infer_type: Traceback (most recent call last):
     File "/home/hanfeng/zyh/mxnet/python/mxnet/operator.py", line 737, in infer_storage_type_backward_entry
       "stypes, got %d."%(total_outputs, len(ostype))
   AssertionError: InferStorageTypeBackward Error: expecting 2 entries in returned output stypes, got 1.
   
   [10:27:12] /home/hanfeng/zyh/mxnet/dmlc-core/include/dmlc/./logging.h:308: [10:27:12] src/operator/custom/custom.cc:383: Check failed: reinterpret_cast<CustomOpBackwardInferStorageTypeFunc>( params.info->callbacks[kCustomOpPropBackwardInferStorageType])( stypes.size(), stypes.data(), params.info->contexts[kCustomOpPropBackwardInferStorageType])
   ```
   cc @eric-haibin-lin @anirudh2290
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. 
   - [ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services