You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/10 06:11:27 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #8390:
[FLINK-12469][table] Clean up catalog API on default/current database
dawidwys commented on a change in pull request #8390: [FLINK-12469][table] Clean up catalog API on default/current database
URL: https://github.com/apache/flink/pull/8390#discussion_r282756500
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -65,9 +64,15 @@
private final Map<ObjectPath, Map<CatalogPartitionSpec, CatalogColumnStatistics>> partitionColumnStats;
public GenericInMemoryCatalog(String name) {
+ this(name, DEFAULT_DB);
+ }
+
+ public GenericInMemoryCatalog(String name, String defaultDatabase) {
Review comment:
How about `GenericInMemoryCatalog(String name, String defaultDatabaseName, CatalogDatabase defaultDatabase)`? I guess we don't need to register additional database if user wants to set a different one.
I think we don't need to check for db existence in the `open` method if we do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services