You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/26 08:56:50 UTC
[GitHub] [airflow] IvanUkhov opened a new pull request #13318: Make package_uris and training_python_module optional
IvanUkhov opened a new pull request #13318:
URL: https://github.com/apache/airflow/pull/13318
Closes #13192.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13318:
URL: https://github.com/apache/airflow/pull/13318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] IvanUkhov commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
IvanUkhov commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-753450266
I have rebased again. Now, it is Pylint that is failing, but it is not clear why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-753457538
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751337878
[The Workflow run](https://github.com/apache/airflow/actions/runs/445310989) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751861446
[The Workflow run](https://github.com/apache/airflow/actions/runs/449516900) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] IvanUkhov commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
IvanUkhov commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751348881
@turbaszek, please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751861274
[The Workflow run](https://github.com/apache/airflow/actions/runs/449516114) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751337940
[The Workflow run](https://github.com/apache/airflow/actions/runs/445295447) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] IvanUkhov commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
IvanUkhov commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751983355
@mik-laj, please take a look at the test. The CI is currently reporting the following error:
```
flask-jwt-extended 3.25.0 has requirement PyJWT<2.0,>=1.6.4, but you have pyjwt 2.0.0.
ERROR: ^^^ Some dependencies are conflicting. See instructions below on how to deal with it.
```
However, this is presumably something orthogonal. If not, please let me know what should be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13318: Make package_uris and training_python_module optional
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751336395
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751527153
LGTM. Can you add unit tests to avoid regression? π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] IvanUkhov edited a comment on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
IvanUkhov edited a comment on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751983355
@mik-laj, please take a look at the test. The CI is currently reporting the following error:
```
msal 1.8.0 has requirement PyJWT[crypto]<2,>=1.0.0, but you have pyjwt 2.0.0.
flask-jwt-extended 3.25.0 has requirement PyJWT<2.0,>=1.6.4, but you have pyjwt 2.0.0.
ERROR: ^^^ Some dependencies are conflicting. See instructions below on how to deal with it.
```
However, this is presumably something orthogonal. If not, please let me know what should be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] IvanUkhov edited a comment on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
IvanUkhov edited a comment on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-751983355
@mik-laj, please take a look at the test. The CI is currently reporting the following error:
```
msal 1.8.0 has requirement PyJWT[crypto]<2,>=1.0.0, but you have pyjwt 2.0.0.
flask-jwt-extended 3.25.0 has requirement PyJWT<2.0,>=1.6.4, but you have pyjwt 2.0.0.
ERROR: ^^^ Some dependencies are conflicting. See instructions below on how to deal with it.
```
However, this is presumably something orthogonal. If not, please let me know what should be changed. (Just in case, I did a rebase just now, but it does not seem to have helped.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-753456400
> I have rebased again. Now, it is Pylint that is failing, but it is not clear why.
Looks like it was too early merged #13403 that caused it. I am fixing it in master now. But let me review this one and we can merge it regardless of that failure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13318: Generalize MLEngineStartTrainingJobOperator to custom images
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13318:
URL: https://github.com/apache/airflow/pull/13318#issuecomment-753445006
I did rebase. It should work now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org