You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "0x26res (via GitHub)" <gi...@apache.org> on 2023/07/23 13:28:10 UTC
[GitHub] [arrow] 0x26res opened a new pull request, #36830: GH-36809: Python MapScalar as_py with custom field name
0x26res opened a new pull request, #36830:
URL: https://github.com/apache/arrow/pull/36830
### Rationale for this change
`MapScalar.as_py` doesn't take into account custom key/value field names
### What changes are included in this PR?
Fix and tests
### Are these changes tested?
Simple unit test
### Are there any user-facing changes?
No API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36830: GH-36809: [Python] MapScalar.as_py with custom field name
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36830:
URL: https://github.com/apache/arrow/pull/36830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] 0x26res commented on pull request #36830: GH-36809: [Python] MapScalar.as_py with custom field name
Posted by "0x26res (via GitHub)" <gi...@apache.org>.
0x26res commented on PR #36830:
URL: https://github.com/apache/arrow/pull/36830#issuecomment-1647417269
That worked, thanks 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36830: GH-36809: Python MapScalar as_py with custom field name
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36830:
URL: https://github.com/apache/arrow/pull/36830#issuecomment-1646841088
:warning: GitHub issue #36809 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36830: GH-36809: [Python] MapScalar.as_py with custom field name
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36830:
URL: https://github.com/apache/arrow/pull/36830#issuecomment-1661376838
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 52ac7185e32f395927d5b7f2aee102ceb8485a98.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `arm64-m6g-linux-compute` at [2023-07-26 15:05:52Z](http://conbench.ursa.dev/compare/runs/02ca987e099b4b4b8b1ca636a995da6e...f87b403d08654eb5801fb45e0234709f/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-14, scale_factor=10](http://conbench.ursa.dev/compare/benchmarks/064c12653e517a8080001796ca2f24ed...064c151c4369751b8000061033036e47)
The [full Conbench report](https://github.com/apache/arrow/runs/15539274301) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] 0x26res commented on pull request #36830: GH-36809: [Python] MapScalar.as_py with custom field name
Posted by "0x26res (via GitHub)" <gi...@apache.org>.
0x26res commented on PR #36830:
URL: https://github.com/apache/arrow/pull/36830#issuecomment-1651335738
@kou do you mind reviewing again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] 0x26res commented on pull request #36830: GH-36809: [Python] MapScalar.as_py with custom field name
Posted by "0x26res (via GitHub)" <gi...@apache.org>.
0x26res commented on PR #36830:
URL: https://github.com/apache/arrow/pull/36830#issuecomment-1647371931
> Could you revert updating submodules? It seems that we don't need them.
I agree, I didn't intend to do that. Do you know which git command I need to run to revert them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36830: GH-36809: [Python] MapScalar.as_py with custom field name
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36830:
URL: https://github.com/apache/arrow/pull/36830#issuecomment-1647404162
The following command lines will work:
```console
$ cd cpp/submodules/parquet-testing
$ git checkout b2e7cc755159196e3a068c8594f7acbaecfdaaac
$ cd -
$ cd testing
$ git checkout 47f7b56b25683202c1fd957668e13f2abafc0f12
$ cd -
$ git add cpp/submodules/parquet-testing testing
$ git commit
$ git push
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36830: GH-36809: [Python] MapScalar.as_py with custom field name
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36830:
URL: https://github.com/apache/arrow/pull/36830#issuecomment-1647076816
Could you revert updating submodules?
It seems that we don't need them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org