You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "JawadAliAbbasi (via GitHub)" <gi...@apache.org> on 2023/01/30 13:40:30 UTC
[GitHub] [age] JawadAliAbbasi opened a new pull request, #637: Added documentation/comments in index.ts file and enhanced readability.
JawadAliAbbasi opened a new pull request, #637:
URL: https://github.com/apache/age/pull/637
Added comments for and within functions to explain their functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani closed pull request #637: Added documentation/comments in index.ts file and enhanced readability.
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani closed pull request #637: Added documentation/comments in index.ts file and enhanced readability.
URL: https://github.com/apache/age/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] JawadAliAbbasi commented on pull request #637: Added documentation/comments in index.ts file and enhanced readability.
Posted by "JawadAliAbbasi (via GitHub)" <gi...@apache.org>.
JawadAliAbbasi commented on PR #637:
URL: https://github.com/apache/age/pull/637#issuecomment-1434588898
I wrote the comments for developers who don't have experience with JS. But I get your point. I will make all these changes the next time.
Thank You
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #637: Added documentation/comments in index.ts file and enhanced readability.
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #637:
URL: https://github.com/apache/age/pull/637#issuecomment-1432304862
@JawadAliAbbasi Can you justify why any of the added documentation is actually necessary? The code seems rather self explanatory. Additionally, your descriptions should strive to make it easier for the reviewer. Is this core code? Is this a driver? If so, which driver? etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org