You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Norbert Sándor (JIRA)" <ta...@jakarta.apache.org> on 2006/07/17 17:22:15 UTC
[jira] Created: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
--------------------------------------------------------------------------------------------------
Key: TAPESTRY-1012
URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
Project: Tapestry
Issue Type: Bug
Components: Framework
Affects Versions: 4.1
Reporter: Norbert Sándor
Is it purposeful?
One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=comments#action_12421775 ]
Jesse Kuhnert commented on TAPESTRY-1012:
-----------------------------------------
Ohhhh...I get it now. You were manually circumventing something and using the Impl version directly.
You can just call cycle.getResponseBuilder() and do what you want with the initialization scripts in there now.
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Jesse Kuhnert
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Norbert Sándor (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=comments#action_12421887 ]
Norbert Sándor commented on TAPESTRY-1012:
------------------------------------------
Please provide some more info on how it should be done.
If you do then I will modify the patch of TAPESTRY-199 to work with 4.1 (and contribute it).
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Jesse Kuhnert
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Reopened: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=all ]
Andreas Andreou reopened TAPESTRY-1012:
---------------------------------------
Assignee: Andreas Andreou (was: Jesse Kuhnert)
I propose changing interface ResponseBuilder and adding a new parameter (IMarkupWriter) to
methods: beginBodyScript, writeImageInitializations, writeBodyScript, endBodyScript, writeInitializationScript.
All calls to this interface are from PageRenderSupportImpl.writeBodyScript which already holds
a reference to the IMarkupWriter, so changes will be minimal.
Only DefaultResponseBuilder will make use of this writer.
This change fixes issues when one wraps @Body with a custom component and
renders it (the @Body) with a custom writer, i.e. a nested writer.
Objections?
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Andreas Andreou
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=all ]
Jesse Kuhnert resolved TAPESTRY-1012.
-------------------------------------
Resolution: Won't Fix
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Jesse Kuhnert
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=all ]
Jesse Kuhnert reassigned TAPESTRY-1012:
---------------------------------------
Assignee: Jesse Kuhnert
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Jesse Kuhnert
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Norbert Sándor (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=comments#action_12421782 ]
Norbert Sándor commented on TAPESTRY-1012:
------------------------------------------
The problem is the following in details. I tried to implement a CSS style component named @Style, similar to the one in TAPESTRY-199.
It uses a nested writer in the Shell component to allow wrapped @Style components to contribute CSS files. The Shell and a wrapped Body are rendered in the following order:
1. a nested writer is created
2. the Shell's body (including the Body component) is rendered to the nested writer
3. <html>, <head>, </head> written
4. the nested writer is closed, so its content is committed to the "real" writer (the "real" writer is the one which was passed to Shell.renderComponent() when the Shell component has begun to render)
5. </hml> is written
At (2), in Body.java at line 187
_pageRenderSupport.writeInitializationScript(writer);
is called, so PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) is called. The problem is here because in PageRenderSupportImpl.java at line 252:
_builder.writeInitializationScript(_initializationScript.toString());
This means that the method PageRenderSupportImpl.writeInitializationScript() does not use its "writer" parameter, so the initialization scripts are written to the "real" writer instead of the nested one created at (1). This results in pages rendered incorrectly like
<script>
... some initialization scripts like Form registration...
</script>
<html>
<head>
...
I hope this helps.
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Jesse Kuhnert
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=comments#action_12421761 ]
Jesse Kuhnert commented on TAPESTRY-1012:
-----------------------------------------
Is there anymore stack trace to this? I have to admit that I'm not familiar with any errors containing "does not use <x> parameter" .
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=all ]
Andreas Andreou resolved TAPESTRY-1012.
---------------------------------------
Fix Version/s: 4.1.1
Resolution: Fixed
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Andreas Andreou
> Fix For: 4.1.1
>
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1012)
PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use
the "writer" parameter
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1012?page=comments#action_12421784 ]
Jesse Kuhnert commented on TAPESTRY-1012:
-----------------------------------------
Yeah, not sure what to say. The "new" way of doing this would be to override the DefaultResponseContributor service to provide your own IMarkupWriter output manager. (contributor)
http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/descriptor/META-INF/tapestry.services.xml?view=markup
> PageRenderSupportImpl.writeInitializationScript(IMarkupWriter) does not use the "writer" parameter
> --------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1012
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1012
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.1
> Reporter: Norbert Sándor
> Assigned To: Jesse Kuhnert
>
> Is it purposeful?
> One of my Tap4.0 components does not work correctly because of this...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org