You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/12/01 08:45:51 UTC
Re: Review Request 64065: Allowed resubscription of resource
providers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64065/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 9:45 a.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-8269
https://issues.apache.org/jira/browse/MESOS-8269
Repository: mesos
Description
-------
A resource provider can resubscribe by including the resource provider
ID it got assigned as part of its 'ResourceProviderInfo' in a
'SUBSCRIBE' call. A resubscription is necessary if either the resource
provider or the resource provider manager (i.e. an agent) failed over.
Diffs (updated)
-----
src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
src/tests/mesos.hpp 99542c599e7d0f5027e9358081822d91b526590e
src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45
src/tests/slave_tests.cpp 1344e0a5376137b5b933edc9ea4a83be58542654
Diff: https://reviews.apache.org/r/64065/diff/4/
Changes: https://reviews.apache.org/r/64065/diff/3-4/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64065: Allowed resubscription of resource
providers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64065/#review192464
-----------------------------------------------------------
Fix it, then Ship it!
Thanks Jan! Will fix minor style nits while committing.
src/tests/mesos.hpp
Lines 2794 (patched)
<https://reviews.apache.org/r/64065/#comment270615>
nit: Let's put these on their own lines.
src/tests/mesos.hpp
Line 2962 (original), 2968 (patched)
<https://reviews.apache.org/r/64065/#comment270616>
Let's add an assertion here that `info.has_id()`.
src/tests/slave_tests.cpp
Lines 8987-8988 (original), 8994-8995 (patched)
<https://reviews.apache.org/r/64065/#comment270617>
nit: Fits on a single line.
src/tests/slave_tests.cpp
Lines 8999-9000 (original), 9006-9007 (patched)
<https://reviews.apache.org/r/64065/#comment270618>
nit: Fits on a single line.
- Benjamin Bannier
On Dec. 1, 2017, 9:45 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64065/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 9:45 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
>
>
> Bugs: MESOS-8269
> https://issues.apache.org/jira/browse/MESOS-8269
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A resource provider can resubscribe by including the resource provider
> ID it got assigned as part of its 'ResourceProviderInfo' in a
> 'SUBSCRIBE' call. A resubscription is necessary if either the resource
> provider or the resource provider manager (i.e. an agent) failed over.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
> src/tests/mesos.hpp 99542c599e7d0f5027e9358081822d91b526590e
> src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45
> src/tests/slave_tests.cpp 1344e0a5376137b5b933edc9ea4a83be58542654
>
>
> Diff: https://reviews.apache.org/r/64065/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64065: Allowed resubscription of resource
providers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64065/#review192475
-----------------------------------------------------------
FAIL: Mesos libprocess-tests failed to build
Failed command: `cmake.exe --build . --target libprocess-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64065
Relevant logs:
- [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64065/logs/libprocess-tests-build-cmake-stdout.log):
```
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
"C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
96 Warning(s)
6 Error(s)
Time Elapsed 00:04:22.75
```
- [libprocess-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64065/logs/libprocess-tests-CMakeOutput.log):
```
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_491d6.dir\Debug\cmTC_491d6.tlog\".
InitializeBuildStatus:
Creating "cmTC_491d6.dir\Debug\cmTC_491d6.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_491d6.dir\Debug\" /Fd"cmTC_491d6.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_491d6.dir\Debug\" /Fd"cmTC_491d6.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_491d6.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_491d6.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_491d6.lib" /MACHINE:X64 /machine:x64 cmTC_491d6.dir\Debug\src.obj
cmTC_491d6.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_491d6.exe
cmTC_491d6.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_491d6.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_491d6.dir\Debug\cmTC_491d6.tlog\unsuccessfulbuild".
Touching "cmTC_491d6.dir\Debug\cmTC_491d6.tlog\cmTC_491d6.lastbuildstate".
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_491d6.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.79
Source file was:
int main() { return 0; }
```
- [libprocess-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64065/logs/libprocess-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_3a57d.dir\Debug\".
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_3a57d.dir\Debug\cmTC_3a57d.tlog\".
InitializeBuildStatus:
Creating "cmTC_3a57d.dir\Debug\cmTC_3a57d.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_3a57d.dir\Debug\" /Fd"cmTC_3a57d.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_3a57d.dir\Debug\" /Fd"cmTC_3a57d.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3a57d.vcxproj]
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3a57d.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3a57d.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_3a57d.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.09
```
- Mesos Reviewbot Windows
On Dec. 1, 2017, 8:45 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64065/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 8:45 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
>
>
> Bugs: MESOS-8269
> https://issues.apache.org/jira/browse/MESOS-8269
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A resource provider can resubscribe by including the resource provider
> ID it got assigned as part of its 'ResourceProviderInfo' in a
> 'SUBSCRIBE' call. A resubscription is necessary if either the resource
> provider or the resource provider manager (i.e. an agent) failed over.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
> src/tests/mesos.hpp 99542c599e7d0f5027e9358081822d91b526590e
> src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45
> src/tests/slave_tests.cpp 1344e0a5376137b5b933edc9ea4a83be58542654
>
>
> Diff: https://reviews.apache.org/r/64065/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>