[GitHub] [bookkeeper] pgier commented on a diff in pull request #3715: [improve][doc] improve bk_server.conf docs

[GitBox <gi...@apache.org>]

pgier commented on code in PR #3715:
URL: https://github.com/apache/bookkeeper/pull/3715#discussion_r1056986345


##########
conf/bk_server.conf:
##########
@@ -41,7 +41,8 @@
 bookiePort=3181
 
 # Configure the bookie to allow/disallow multiple ledger/index/journal directories
-# in the same filesystem disk partition
+# in the same filesystem disk partition.
+# Defaults to true.
 # allowMultipleDirsUnderSameDiskPartition=false

Review Comment:
   @eolivelli I thought that wouldn't affect the default value since it's commented out?  Wouldn't it still default to true based on the [sources](https://github.com/apache/bookkeeper/blob/032aef7e75f6b3487a6611a2b8af8306b9a3f7bb/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java#L3499-L3500).
   
   I wasn't sure if the commented out examples were supposed to match the default values, or were to there to provide an each way to uncomment and override the default value.  I think there are examples of both cases currently in the config file.  Setting it to match the default value as @nicoloboschi suggested does seem a bit more intuitive to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org