You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2016/06/24 19:02:01 UTC
[Impala-CR](cdh5-trunk) Remove some code in like-predicate-ir.cc from cross-compilation
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3483
Change subject: Remove some code in like-predicate-ir.cc from cross-compilation
......................................................................
Remove some code in like-predicate-ir.cc from cross-compilation
like-predicate-ir.cc contains a lot of code which
won't be called and inlined by other IR functions.
(e.g. the prepare functions). To reduce the size of
the bitcode module, this change removes these functions
from cross compilation and moves them into like-predicate.cc
instead.
Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
---
M be/src/exprs/CMakeLists.txt
M be/src/exprs/like-predicate-ir.cc
A be/src/exprs/like-predicate.cc
M be/src/exprs/like-predicate.h
4 files changed, 424 insertions(+), 390 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/83/3483/1
--
To view, visit http://gerrit.cloudera.org:8080/3483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-CR](cdh5-trunk) Remove some code in like-predicate-ir.cc from cross-compilation
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: Remove some code in like-predicate-ir.cc from cross-compilation
......................................................................
Remove some code in like-predicate-ir.cc from cross-compilation
like-predicate-ir.cc contains a lot of code which
won't be called and inlined by other IR functions.
(e.g. the prepare functions). To reduce the size of
the bitcode module, this change removes these functions
from cross compilation and moves them into like-predicate.cc
instead.
Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Reviewed-on: http://gerrit.cloudera.org:8080/3483
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exprs/CMakeLists.txt
M be/src/exprs/like-predicate-ir.cc
A be/src/exprs/like-predicate.cc
M be/src/exprs/like-predicate.h
4 files changed, 424 insertions(+), 390 deletions(-)
Approvals:
Michael Ho: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) Remove some code in like-predicate-ir.cc from cross-compilation
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Remove some code in like-predicate-ir.cc from cross-compilation
......................................................................
Patch Set 2: Code-Review+1
Carry Tim's +1 forward.
--
To view, visit http://gerrit.cloudera.org:8080/3483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Remove some code in like-predicate-ir.cc from cross-compilation
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Remove some code in like-predicate-ir.cc from cross-compilation
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Remove some code in like-predicate-ir.cc from cross-compilation
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Remove some code in like-predicate-ir.cc from cross-compilation
......................................................................
Patch Set 1: Code-Review+1
Thanks for doing this
--
To view, visit http://gerrit.cloudera.org:8080/3483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Remove some code in like-predicate-ir.cc from cross-compilation
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: Remove some code in like-predicate-ir.cc from cross-compilation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Remove some code in like-predicate-ir.cc from cross-compilation
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Remove some code in like-predicate-ir.cc from cross-compilation
......................................................................
Patch Set 3: Code-Review+2
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/3483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1279622ff97af0e1bedcfd9aafdb875b01e38c7c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No