You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "nvollmar (via GitHub)" <gi...@apache.org> on 2023/05/09 05:09:16 UTC

[GitHub] [incubator-pekko-connectors] nvollmar opened a new pull request, #100: updates Cassandra driver

nvollmar opened a new pull request, #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #100: updates Cassandra driver

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1539804991

   As stated in https://github.com/apache/incubator-pekko-persistence-cassandra/pull/35#pullrequestreview-1418234767 I will approve this PR but lets wait for a week before merging to see if @pjfanning has any objections


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] nvollmar commented on a diff in pull request #100: updates Cassandra driver

Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#discussion_r1188492635


##########
project/Dependencies.scala:
##########
@@ -110,7 +110,7 @@ object Dependencies {
     ))
 
   val CassandraVersionInDocs = "4.0"
-  val CassandraDriverVersion = "4.13.0"
+  val CassandraDriverVersion = "4.15.0"
   val CassandraDriverVersionInDocs = "4.13"

Review Comment:
   yep, that might have gotten lost when I updated the PR. Will fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #100: updates Cassandra driver

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1539742900

   I actually wanted to entertain the idea in general, i.e. updating all of the drivers in connectors to their latest respective versions, @pjfanning wdyt?
   
   @nvollmar is `4.15.0` is fully compatible with `4.13.0`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] nvollmar commented on a diff in pull request #100: updates Cassandra driver

Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#discussion_r1188492635


##########
project/Dependencies.scala:
##########
@@ -110,7 +110,7 @@ object Dependencies {
     ))
 
   val CassandraVersionInDocs = "4.0"
-  val CassandraDriverVersion = "4.13.0"
+  val CassandraDriverVersion = "4.15.0"
   val CassandraDriverVersionInDocs = "4.13"

Review Comment:
   yep, will fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #100: updates Cassandra driver

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1543493876

   Cool, ill wait to see if @pjfanning has any objections.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #100: updates Cassandra driver

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #100: updates Cassandra driver

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1543535517

   it's ok to merge this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #100: updates Cassandra driver

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1543450005

   @pjfanning @nvollmar Shall I merge this PR so its included in the next snapshot that I will be pushing into all of the dependant projects?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] nvollmar commented on pull request #100: updates Cassandra driver

Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1543472336

   @mdedetrich 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] nvollmar commented on pull request #100: updates Cassandra driver

Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1539760452

   We've been running with 4.14.1 and 4.15.0 without issues for a long time.
   The changelog is here: https://github.com/datastax/java-driver/blob/4.x/changelog/README.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #100: updates Cassandra driver

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#issuecomment-1539753416

   Ah I just got the context from https://github.com/apache/incubator-pekko-persistence-cassandra


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #100: updates Cassandra driver

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko-connectors/pull/100#discussion_r1188456676


##########
project/Dependencies.scala:
##########
@@ -110,7 +110,7 @@ object Dependencies {
     ))
 
   val CassandraVersionInDocs = "4.0"
-  val CassandraDriverVersion = "4.13.0"
+  val CassandraDriverVersion = "4.15.0"
   val CassandraDriverVersionInDocs = "4.13"

Review Comment:
   should CassandraDriverVersionInDocs be updated too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org