[GitHub] [incubator-druid] gianm commented on a change in pull request #8903: S3 input source

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #8903: S3 input source
URL: https://github.com/apache/incubator-druid/pull/8903#discussion_r348529598
 
 

 ##########
 File path: extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3Entity.java
 ##########
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.data.input.s3;
+
+import com.amazonaws.services.s3.model.AmazonS3Exception;
+import com.amazonaws.services.s3.model.S3Object;
+import com.google.common.base.Predicate;
+import org.apache.druid.data.input.InputEntity;
+import org.apache.druid.java.util.common.ISE;
+import org.apache.druid.storage.s3.S3Utils;
+import org.apache.druid.storage.s3.ServerSideEncryptingAmazonS3;
+import org.apache.druid.utils.CompressionUtils;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+
+public class S3Entity implements InputEntity
+{
+  private final ServerSideEncryptingAmazonS3 s3Client;
+  private final URI uri;
+
+  S3Entity(ServerSideEncryptingAmazonS3 s3Client, URI uri)
+  {
+    this.s3Client = s3Client;
+    this.uri = uri;
+  }
+
+  @Override
+  public URI getUri()
+  {
+    return uri;
+  }
+
+  @Override
+  public InputStream open() throws IOException
+  {
+    try {
+      // Get data of the given object and open an input stream
+      final String bucket = uri.getAuthority();
+      final String key = S3Utils.extractS3Key(uri);
+
+      final S3Object s3Object = s3Client.getObject(bucket, key);
+      if (s3Object == null) {
+        throw new ISE("Failed to get an s3 object for bucket[%s] and key[%s]", bucket, key);
+      }
+      return CompressionUtils.decompress(s3Object.getObjectContent(), uri.toString());
 
 Review comment:
   minor: It doesn't matter much, but `uri.getPath()` would be better here, because `uri.toString()` URI-encodes its values.
   
   Actually, `key` would be even better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org