You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "gaozhangmin (via GitHub)" <gi...@apache.org> on 2023/06/28 02:29:05 UTC
[GitHub] [bookkeeper] gaozhangmin opened a new pull request, #4003: AddRequestStats metric is missed
gaozhangmin opened a new pull request, #4003:
URL: https://github.com/apache/bookkeeper/pull/4003
### Motivation
Before #3848，Bookie sent response by `org.apache.bookkeeper.proto.PacketProcessorBase#sendResponse`
And we record the add request stat in this method.
```
if (BookieProtocol.EOK == rc) {
statsLogger.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
} else {
statsLogger.registerFailedEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
}
```
Now, we implement an new flush strategy, and missed record add request stat.
### Changes
Record add request stat in `writeComplete `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin closed pull request #4003: AddRequestStats metric is missed
Posted by "gaozhangmin (via GitHub)" <gi...@apache.org>.
gaozhangmin closed pull request #4003: AddRequestStats metric is missed
URL: https://github.com/apache/bookkeeper/pull/4003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org