You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Kristen Legacy <kr...@gmail.com> on 2012/08/01 18:28:19 UTC

Review Request: RAVE-532: Bootstrap-enable widget controls (hide gadget menu)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6286/
-----------------------------------------------------------

Review request for rave.


Description
-------

Adding overlay to capture iframe click events to collapse gadget menu and JS to remove overlay when clicking anywhere within the parent page. Also sneaking in minor fix to page.jsp (container-fluid div was closed before elements with row-fluid).

https://issues.apache.org/jira/browse/RAVE-532


Diffs
-----

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1367966 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1367966 
  trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1367966 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1367966 

Diff: https://reviews.apache.org/r/6286/diff/


Testing
-------


Thanks,

Kristen Legacy

Re: Review Request: RAVE-532: Bootstrap-enable widget controls (hide gadget menu)

Posted by Chris Geer <ch...@cxtsoftware.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6286/#review9996
-----------------------------------------------------------



trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag
<https://reviews.apache.org/r/6286/#comment21171>

    What is the value of adding the triggerOverlays class? I can't seem to find that being defined anywhere. Where should I be looking?



trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag
<https://reviews.apache.org/r/6286/#comment21172>

    Was the empty script block intentional?


- Chris Geer


On Aug. 1, 2012, 4:28 p.m., Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6286/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 4:28 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Adding overlay to capture iframe click events to collapse gadget menu and JS to remove overlay when clicking anywhere within the parent page. Also sneaking in minor fix to page.jsp (container-fluid div was closed before elements with row-fluid).
> 
> https://issues.apache.org/jira/browse/RAVE-532
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1367966 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1367966 
>   trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1367966 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1367966 
> 
> Diff: https://reviews.apache.org/r/6286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen Legacy
> 
>

Re: Review Request: RAVE-532: Bootstrap-enable widget controls (hide gadget menu)

Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6286/
-----------------------------------------------------------

(Updated Oct. 4, 2012, 6:43 p.m.)


Review request for rave.


Description
-------

Adding overlay to capture iframe click events to collapse gadget menu and JS to remove overlay when clicking anywhere within the parent page. Also sneaking in minor fix to page.jsp (container-fluid div was closed before elements with row-fluid).

https://issues.apache.org/jira/browse/RAVE-532


Diffs (updated)
-----

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1394186 
  trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1394186 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1394186 

Diff: https://reviews.apache.org/r/6286/diff/


Testing
-------


Thanks,

Kristen Legacy

Re: Review Request: RAVE-532: Bootstrap-enable widget controls (hide gadget menu)

Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6286/
-----------------------------------------------------------

(Updated Oct. 4, 2012, 6:40 p.m.)


Review request for rave.


Changes
-------

I'm afraid those both are relics I failed to remove before creating the patch. Attaching update patch file.


Description
-------

Adding overlay to capture iframe click events to collapse gadget menu and JS to remove overlay when clicking anywhere within the parent page. Also sneaking in minor fix to page.jsp (container-fluid div was closed before elements with row-fluid).

https://issues.apache.org/jira/browse/RAVE-532


Diffs (updated)
-----

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1394186 
  trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1394186 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1394186 

Diff: https://reviews.apache.org/r/6286/diff/


Testing
-------


Thanks,

Kristen Legacy